Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

uncomment check to verify vm name is same on esx/docker host as reported by govc #1487

Merged

Conversation

ashahi1
Copy link
Contributor

@ashahi1 ashahi1 commented Jun 27, 2017

Uncomment the code to verify vm name is same on esx and docker host as reported by govc
#1284 (comment)

Ran all the e2e-tests and all tests passed other than swarm test. Swarm tests failed because I wasn't having swarm setup.

=> Running target test-e2e-runalways
OK: 6 passed
--- PASS: Test (111.40s)
PASS
ok  	github.com/vmware/docker-volume-vsphere/tests/e2e	111.401s

=> Running target test-e2e-runonce
OOPS: 21 passed, 3 skipped, 2 FAILED, 1 MISSED
--- FAIL: Test (401.19s)
FAIL
exit status 1
FAIL	github.com/vmware/docker-volume-vsphere/tests/e2e	401.198s

@lipingxue
Copy link
Contributor

What is the purpose of this PR?

@ashahi1 ashahi1 force-pushed the uncommentVerificationCode.ashahi1 branch from a389840 to 6474fe5 Compare June 27, 2017 17:36
@ashahi1
Copy link
Contributor Author

ashahi1 commented Jun 27, 2017

@lipingxue #1284 (comment)

So I am uncommenting the lines which were commented out in PR #1276

@shaominchen
Copy link
Contributor

shaominchen commented Jun 27, 2017

@ashahi1 We shouldn't disable swarm test. The real issue here is with RetrieveVMNameFromIP itself. Please investigate further before re-enabling this function. I don't think we have truly figured out the root cause of the previous issue that we have identified about RetrieveVMNameFromIP.

@ashahi1
Copy link
Contributor Author

ashahi1 commented Jun 28, 2017

@shaominchen We already know swarm test has test issue - Issue #1490
Disabled swarm test because need to find out if other tests have similar test issues.

@ashahi1
Copy link
Contributor Author

ashahi1 commented Jun 28, 2017

It looks like only swarm test fails after we uncomment the lines in VerifyAttachedStatus method. Will wait for CI run to finish.
So, for this PR to merge, issue #1490 needs to be fixed first.
https://github.com/vmware/docker-volume-vsphere/blob/master/tests/utils/verification/volumeproperties.go#L104

/cc @shuklanirdesh82

Copy link
Contributor

@shuklanirdesh82 shuklanirdesh82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's enable the check.

By taking reference of #1487 (comment) .. It is good to enable the check as only one test is blocking this enablement.

… docker host to the vm name reported by govc

2. Added unstable tag to swarm test to make it not run on CI - Issue # 1490
@ashahi1 ashahi1 force-pushed the uncommentVerificationCode.ashahi1 branch from d46ac4a to 165dbca Compare June 28, 2017 06:16
@ashahi1
Copy link
Contributor Author

ashahi1 commented Jun 28, 2017

As per offline discussion with Sam, added unstable tag to swarm test so that swarm test does not run on CI till issue #1490 is fixed.

/cc @shaominchen

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants