-
Notifications
You must be signed in to change notification settings - Fork 95
uncomment check to verify vm name is same on esx/docker host as reported by govc #1487
uncomment check to verify vm name is same on esx/docker host as reported by govc #1487
Conversation
What is the purpose of this PR? |
a389840
to
6474fe5
Compare
So I am uncommenting the lines which were commented out in PR #1276 |
@ashahi1 We shouldn't disable swarm test. The real issue here is with RetrieveVMNameFromIP itself. Please investigate further before re-enabling this function. I don't think we have truly figured out the root cause of the previous issue that we have identified about RetrieveVMNameFromIP. |
@shaominchen We already know swarm test has test issue - Issue #1490 |
It looks like only swarm test fails after we uncomment the lines in VerifyAttachedStatus method. Will wait for CI run to finish. /cc @shuklanirdesh82 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's enable the check.
By taking reference of #1487 (comment) .. It is good to enable the check as only one test is blocking this enablement.
… docker host to the vm name reported by govc 2. Added unstable tag to swarm test to make it not run on CI - Issue # 1490
d46ac4a
to
165dbca
Compare
As per offline discussion with Sam, added unstable tag to swarm test so that swarm test does not run on CI till issue #1490 is fixed. /cc @shaominchen |
Uncomment the code to verify vm name is same on esx and docker host as reported by govc
#1284 (comment)
Ran all the e2e-tests and all tests passed other than swarm test. Swarm tests failed because I wasn't having swarm setup.