Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Commit

Permalink
1. Uncommenting code to verify attached-to-vm name is same at esx and…
Browse files Browse the repository at this point in the history
… docker host to the vm name reported by govc

2. Added unstable tag to swarm test to make it not run on CI - Issue # 1490
  • Loading branch information
ashahi1 committed Jun 28, 2017
1 parent fa7944f commit 165dbca
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion tests/e2e/swarm_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
// This test suite includes test cases to verify basic vDVS functionality
// in docker swarm mode.

// +build runonce
// +build unstable

package e2e

Expand Down
8 changes: 4 additions & 4 deletions tests/utils/verification/volumeproperties.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import (
"github.com/vmware/docker-volume-vsphere/tests/constants/admincli"
"github.com/vmware/docker-volume-vsphere/tests/constants/dockercli"
"github.com/vmware/docker-volume-vsphere/tests/constants/properties"
"github.com/vmware/docker-volume-vsphere/tests/utils/esx"
"github.com/vmware/docker-volume-vsphere/tests/utils/misc"
"github.com/vmware/docker-volume-vsphere/tests/utils/ssh"
)
Expand Down Expand Up @@ -106,13 +107,12 @@ func VerifyAttachedStatus(name, hostName, esxName string) bool {

vmAttachedHost := GetVMAttachedToVolUsingDockerCli(name, hostName)
vmAttachedESX := GetVMAttachedToVolUsingAdminCli(name, esxName)
//expectedVMName := esx.RetrieveVMNameFromIP(hostName)
expectedVMName := esx.RetrieveVMNameFromIP(hostName)

//isMatching := ((vmAttachedHost == expectedVMName) && (vmAttachedHost == vmAttachedESX))
isMatching := (vmAttachedHost == vmAttachedESX)
isMatching := ((vmAttachedHost == expectedVMName) && (vmAttachedHost == vmAttachedESX))

if !isMatching {
//log.Printf("Expected Attached VM name is [%s]", expectedVMName)
log.Printf("Expected Attached VM name is [%s]", expectedVMName)
log.Printf("Attached VM name from Docker CLI is [%s]", vmAttachedHost)
log.Printf("Attached VM name from Admin CLI is [%s]", vmAttachedESX)
}
Expand Down

0 comments on commit 165dbca

Please sign in to comment.