Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAFV-466][1.3.z] bring CLUSTERCTL.md and CRS.md up to date #633

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

rliang88
Copy link
Contributor

@rliang88 rliang88 commented Mar 28, 2024

Description

Please provide a brief description of the changes proposed in this Pull Request

  • use relevant CRS versions in CLUSTERCTL.md
  • CRS.md examples tell users they can use custom path

Checklist

  • tested locally
  • updated any relevant dependencies
  • updated any relevant documentation or examples

API Changes

Are there API changes?

  • Yes
  • No

If yes, please fill in the below

  1. Updated conversions?
    • Yes
    • No
    • N/A
  2. Updated CRDs?
    • Yes
    • No
    • N/A
  3. Updated infrastructure-components.yaml?
    • Yes
    • No
    • N/A
  4. Updated ./examples/capi-quickstart.yaml?
    • Yes
    • No
    • N/A
  5. Updated necessary files under ./infrastructure-vcd/v1.0.0/?
    • Yes
    • No
    • N/A

Issue

If applicable, please reference the relevant issue

Fixes #


This change is Reviewable

Copy link
Contributor

@lzichong lzichong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @rliang88 and @sahithi)


docs/CRS.md line 12 at r1 (raw file):

## Apply CRS definitions on the (parent) management cluster

To install CRS components on the management cluster, in CAPVCD repo, copy the contents of [templates](https://github.com/vmware/cluster-api-provider-cloud-director/tree/main/templates/crs)

Wondering if this should point to main or 1.3.z as 1.1.z PR points to 1.1.z; this is more from a consistency pov, as I think pointing to main is also okay as it would have the latest CRS files which can be applied

Copy link
Contributor

@lzichong lzichong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @rliang88 and @sahithi)

Copy link
Contributor

@lzichong lzichong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rliang88 and @sahithi)

@rliang88 rliang88 merged commit 925f671 into vmware:1.3.z Apr 3, 2024
1 check was pending
@rliang88 rliang88 deleted the rl/CAFV-466-1.3.z branch April 3, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants