[CAFV-449][1.3.z] update CLUSTERCTL.md with updated versions #614
Conversation
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @rliang88 and @sahithi)
docs/CLUSTERCTL.md line 22 at r1 (raw file):
1. Run the below command to initialize the management cluster with the Cluster API and the associated provider for VMware Cloud Director. Ensure the version interop between CAPVCD, Core CAPI, and Clusterctl are correct from the [interop version table](#version-interop) 1. For CAPVCD `main`, use `clusterctl init --core cluster-api:v1.4.0 -b kubeadm:v1.4.0 -c kubeadm:v1.4.0 -i vcd:v1.1.0`
I think the versions should be updated here as well
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @rliang88 and @sahithi)
docs/CLUSTERCTL.md line 46 at r1 (raw file):
- All of the templates to generate the cluster manifests are located at `templates` directory under the root of the github repository. - All the flavors listed support only v1beta1 API versions of CAPVCD and Core CAPI. - Currently, we have v1.20.8, v1.21.8, v1.22.9, v1.23.10 as template flavors, and they each have their own etcd/dns versions pre-populated.
Possibly we can also update this list of versions to the latest kubernetes versions that we have in the templates folder
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @rliang88 and @sahithi)
| | 1.1.z | v1.4.0 | | ||
| | 1.0.z | v1.1.3 | | ||
|
|
||
| <a name="clusterctl_set_up"></a> | ||
| ## Set up | ||
| Install [clusterctl](https://cluster-api.sigs.k8s.io/user/quick-start.html#install-clusterctl) according to the [version interop table](#version-interop). |
There was a problem hiding this comment.
Please keep this line of clusterctl installation
docs/CLUSTERCTL.md
Outdated
| ## Initialize Management cluster | ||
|
|
||
| 1. Run the below command to initialize the management cluster with the Cluster API and the associated provider for VMware Cloud Director. Ensure the version interop between CAPVCD, Core CAPI, and Clusterctl are correct from the [interop version table](#version-interop) | ||
| 1. For CAPVCD `main`, use `clusterctl init --core cluster-api:v1.4.0 -b kubeadm:v1.4.0 -c kubeadm:v1.4.0 -i vcd:v1.1.0` |
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on @lzichong and @sahithi)
docs/CLUSTERCTL.md line 22 at r1 (raw file):
Previously, lzichong wrote…
I think the versions should be updated here as well
Done.
docs/CLUSTERCTL.md line 46 at r1 (raw file):
Previously, lzichong wrote…
Possibly we can also update this list of versions to the latest kubernetes versions that we have in the templates folder
Done.
docs/CLUSTERCTL.md line 22 at r2 (raw file):
Previously, sahithi (Sahithi Ayloo) wrote…
vcd:v1.3.0
Done.
Description
Please provide a brief description of the changes proposed in this Pull Request
Checklist
API Changes
Are there API changes?
If yes, please fill in the below
./examples/capi-quickstart.yaml?./infrastructure-vcd/v1.0.0/?Issue
If applicable, please reference the relevant issue
Fixes #
This change is