Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ecmascript] (#402) Remove unused function Export.from from class Module #411

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

bcpmihail
Copy link
Contributor

@bcpmihail bcpmihail commented Sep 10, 2024

Description

Removed the function Module.export.from as discussed on roadmap meeting.
The function 'from' is not part of the interface ModuleExport and is not used anywhere within the project.

Checklist

  • I have added relevant error handling and logging messages to help troubleshooting
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation, relevant usage information (if applicable)
  • I have updated the PR title with affected component, related issue number and a short summary of the changes introduced
  • I have added labels for implementation kind (kind/) and version type (version/)
  • I have tested against live environment, if applicable
  • I have synced any structure and/or content vRA-NG improvements with vra-ng and ts-vra-ng archetypes (if applicable)
  • I have my changes rebased and squashed to the minimal number of relevant commits. Notice: don't squash all commits
  • I have added a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Pushed to test environment without issue.

Related issues and PRs


Closes #402

Signed-off-by: Mihail Penchev (c) <pmihail@vmware.com>
@bcpmihail bcpmihail added lang/typescript Related to typescript code kind/skip-changelog Release Drafter: Don't add to the release changelog area/ecmascript Relates to ecmascript module labels Sep 10, 2024
@bcpmihail bcpmihail self-assigned this Sep 10, 2024
@bcpmihail bcpmihail requested a review from a team as a code owner September 10, 2024 12:49
@bcpmihail bcpmihail linked an issue Sep 10, 2024 that may be closed by this pull request
@github-actions github-actions bot added the kind/feature New Feature to the project label Sep 10, 2024
@VenelinBakalov VenelinBakalov changed the title [ecmascript] (402) Removed unused function Module - export from [ecmascript] (402) Remove unused function Export.from from class Module Sep 10, 2024
@VenelinBakalov VenelinBakalov added version/patch The change is a non-breaking bugfix kind/enhancement Enhancement or improvement of existing features and removed kind/skip-changelog Release Drafter: Don't add to the release changelog kind/feature New Feature to the project labels Sep 10, 2024
@bcpmihail bcpmihail merged commit 4c2e6e5 into main Sep 10, 2024
15 checks passed
@VenelinBakalov VenelinBakalov deleted the feature/402-deprecate-module-export-from branch September 11, 2024 06:09
@VenelinBakalov VenelinBakalov changed the title [ecmascript] (402) Remove unused function Export.from from class Module [ecmascript] (#402) Remove unused function Export.from from class Module Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ecmascript Relates to ecmascript module kind/enhancement Enhancement or improvement of existing features lang/typescript Related to typescript code version/patch The change is a non-breaking bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate Module - export from
2 participants