Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vrotsc,vrotsc-annotations] (#324) Canvas Error Handling Feature XML Tag Fix #373

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

akantchev
Copy link
Contributor

@akantchev akantchev commented Aug 2, 2024

(#324) Canvas Error Handling Feature XML Tag Fix

Description

Fix for the error handling canvas item introduced with #371 that prevents the package to be generated (due to XML tag errors).

Checklist

  • I have added relevant error handling and logging messages to help troubleshooting
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the PR title with affected component, related issue number and a short summary of the changes introduced
  • I have added labels for implementation kind (kind/) and version type (version/)
  • I have tested against live environment, if applicable
  • I have my changes rebased and squashed to the minimal number of relevant commits. Notice: don't squash all commits
  • I have added a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

  1. Create a typescript package with single workflow defined in typescript.
  2. Build the package.
  3. Push to a live environment.

Release Notes

Fix for the error handling canvas item introduced with #371 that prevents the package to be generated (due to XML tag errors).

Related issues and PRs

Resolves issue related to the feature #324

…nents.

Signed-off-by: Alexander Kantchev <akantchev@vmware.com>
@akantchev akantchev added lang/typescript Related to typescript code area/vrotsc Relates to `vrotsc` module version/minor Introduces a non-breaking feature or change kind/skip-changelog Release Drafter: Don't add to the release changelog labels Aug 2, 2024
@akantchev akantchev requested a review from a team as a code owner August 2, 2024 12:53
@github-actions github-actions bot added the kind/bug Something isn't working label Aug 2, 2024
@akantchev akantchev removed the request for review from VenelinBakalov August 2, 2024 13:18
@akantchev akantchev merged commit 843f311 into main Aug 2, 2024
13 checks passed
@VenelinBakalov VenelinBakalov deleted the bugfix/324-canvas-item-error-handling-xml-error branch August 2, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vrotsc Relates to `vrotsc` module kind/bug Something isn't working kind/skip-changelog Release Drafter: Don't add to the release changelog lang/typescript Related to typescript code version/minor Introduces a non-breaking feature or change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants