Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#368) Bump maven-assembly-plugin and maven-dependency-plugin to 3.7.1 #369

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

pe1pip
Copy link
Contributor

@pe1pip pe1pip commented Jul 31, 2024

Description

Bump maven-assembly-plugin and maven-dependency-plugin to 3.7.1

Checklist

  • I have added relevant error handling and logging messages to help troubleshooting
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation, relevant usage information (if applicable)
  • I have updated the PR title with affected component, related issue number and a short summary of the changes introduced
  • I have added labels for implementation kind (kind/) and version type (version/)
  • I have tested against live environment, if applicable
  • I have synced any structure and/or content vRA-NG improvements with vra-ng and ts-vra-ng archetypes (if applicable)
  • I have my changes rebased and squashed to the minimal number of relevant commits. Notice: don't squash all commits
  • I have added a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Sorry guys, no testing, just quick PR as a suggestion

Release Notes

[base-package] maven-assembly-plugin and maven-dependency-plugin to 3.7.1

Related issues and PRs

#368

Signed-off-by: Remco Post <Remco.Post@rabobank.nl>
@pe1pip pe1pip requested a review from a team as a code owner July 31, 2024 12:37
@vmwclabot
Copy link
Member

@pe1pip, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

1 similar comment
@vmwclabot
Copy link
Member

@pe1pip, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@github-actions github-actions bot added the kind/dependencies Pull requests that update a dependency file label Jul 31, 2024
@VenelinBakalov VenelinBakalov added version/minor Introduces a non-breaking feature or change area/maven Relates to maven changes labels Aug 1, 2024
@VenelinBakalov
Copy link
Collaborator

Hi @pe1pip , I think we are ready to merge this one, could you resolve the remaining merge conflict?

Copy link
Collaborator

@VenelinBakalov VenelinBakalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending merge conflict

@vmwclabot
Copy link
Member

@pe1pip, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

1 similar comment
@vmwclabot
Copy link
Member

@pe1pip, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@VenelinBakalov VenelinBakalov merged commit 4f61216 into vmware:main Aug 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maven Relates to maven changes dco-required kind/dependencies Pull requests that update a dependency file version/minor Introduces a non-breaking feature or change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants