-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ecmascript] (#361) Add Object support in Array.from()
method
#362
Conversation
…in order to be compatible with Array.from() Signed-off-by: Alexander Kantchev <akantchev@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change does not resolve my issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending review on the documentation changes by @ktsonchev .
In the meantime, @Michaelpalacce and @akantchev please double check if there are any other changes required purely from code perspective and we will align next week.
Signed-off-by: Alexander Kantchev <akantchev@vmware.com>
… for non indexed ones. Signed-off-by: Alexander Kantchev <akantchev@vmware.com>
Signed-off-by: Alexander Kantchev <akantchev@vmware.com>
Thanks everyone! This should now correctly resolve #361 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry something came to mind later regarding honoring the functions return type
Requested changes were applied
thank you for your suggestions and support as well! |
Array.from()
method
Description
Add support of objects in the
VROES.Shims.arrayFrom()
method so its behavior is similar to the standardArray.from()
method.Checklist
Fixed #XXX -
orClosed #XXX -
prefix to auto-close the issueTesting
Test Screenshot
Release Notes
Add support of objects in the
VROES.Shims.arrayFrom()
method so its behavior is similar to the standardArray,from()
method.Related issues and PRs
Resolves #361