[artifact-manager] [archetypes/vra] (#210) Cloud Template folder name and the name from details.json mismatch issue fixed in vRA

[sugeeshC]

Description

Cloud Template folder name and details.json->name mismatch issue fixed.

Previous Behavior

• When Cloud-Template folder name and details.json->name mismatch, folder name is used for validating if the record exists on the server and details.json->name is used for creating/updating the cloud template on server.

Current Behavior

• When Cloud-Template folder name and details.json->name mismatch, now an error throwing explaining the mismatch.

• details.json->name is now used for both validating and creating/updating cloud template on the server.

Checklist

• I have added relevant error handling and logging messages to help troubleshooting
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation, relevant usage information (if applicable)
• I have updated the PR title with affected component, related issue number and a short summary of the changes introduced
• I have added labels for implementation type (enhancement, bug, dependencies) and version change (major, minor, patch)
• I have tested against live environment, if applicable
• I have synced any structure and/or content vRA-NG improvements with vra-ng and ts-vra-ng archetypes (if applicable)
• I have my changes rebased and squashed to the minimal number of relevant commits. Notice: don't squash all commits
• I have added a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

1.) Create vra 8 project using build-tools-for-vmware-aria.
2.) Create blueprint folder(Test-Blueprint-1) and content.yaml, details.json files accordingly.
3.) Add the blueprint folder name(Test-Blueprint-1) in project content.yaml.
4.) Change the details.json->name value into different from blueprint folder name. (Test-Blueprint-2)
5.) Push project to vra server.

Release Notes

[artifact-manager] (#210) Cloud Template folder name and details.json->name mismatch issue fixed in vra.

Related issues and PRs

Closed #210

Additional Notes

Please note that, this fix is applying only when, we have a 'blueprint folder' named as in the project 'content.yaml'.

Examples

• Scenario 1 - Fix will be applied in this scenario.

content.yaml

blueprint:
  - Test-1

blueprints/Test-1/details.json

{
  "name": "Test-2",
  "description": "",
  "requestScopeOrg": false
}

• Scenario 2 - Fix would not applied in following scenario. ( Since there is no 'Test-1' folder, blueprint will be skipped. )

content.yaml

blueprint:
  - Test-1

blueprints/Test-2/details.json

{
  "name": "Test-1",
  "description": "",
  "requestScopeOrg": false
}

For the second scenario, this is the current behavior as well.

[sugeeshC]

Please note that, this fix is applying only when, we have a 'blueprint folder' named as in the project 'content.yaml'.

eg -

• scenario 1 - Fix will be applied in this scenario.

content.yaml

blueprint:
  - Test-1

blueprints/Test-1/details.json

{
  "name": "Test-2",
  "description": "",
  "requestScopeOrg": false
}

• scenario 2 - Fix would not applied in following scenario. ( Since there is no 'Test-1' folder, blueprint will be skipped. )

content.yaml

blueprint:
  - Test-1

blueprints/Test-2/details.json

{
  "name": "Test-1",
  "description": "",
  "requestScopeOrg": false
}

For the second scenario, this is the existing behavior as well.

[vmwclabot]

@sugeeshC, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit b615015 has a no-reply/unreachable author email address: 157010648+sugeeshC@users.noreply.github.com

[vmwclabot]

@sugeeshC, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit b615015 has a no-reply/unreachable author email address: 157010648+sugeeshC@users.noreply.github.com

[vmwclabot]

@sugeeshC, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 17ed27e has a no-reply/unreachable author email address: 157010648+sugeeshC@users.noreply.github.com

[vmwclabot]

@sugeeshC, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 17ed27e has a no-reply/unreachable author email address: 157010648+sugeeshC@users.noreply.github.com