Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert VcKeyAnyValue from interface to class #285

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Convert VcKeyAnyValue from interface to class #285

merged 1 commit into from
Jun 12, 2024

Conversation

unbreakabl3
Copy link
Contributor

@unbreakabl3 unbreakabl3 commented Jun 12, 2024 •
edited by Michaelpalacce
Loading

Description

Checklist

  • I have added relevant error handling and logging messages to help troubleshooting
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation, relevant usage information (if applicable)
  • I have updated CHANGELOG.md with a short summary of the changes introduced
  • I have tested against live environment, if applicable
  • I have synced any structure and/or content vRA-NG improvements with vra-ng and ts-vra-ng archetypes (if applicable)
  • I have my changes rebased and squashed to the minimal number of relevant commits. Notice: don't squash all commits
  • I have added a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Release Notes

Related issues and PRs

@unbreakabl3
Convert VcKeyAnyValue from interface to class
36a29f5 
Signed-off-by: Leonid Belenkiy <cozies_archway.0b@icloud.com>
@unbreakabl3 unbreakabl3 requested a review from a team as a code owner June 12, 2024 15:13
Michaelpalacce
Michaelpalacce approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@Michaelpalacce Michaelpalacce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Michaelpalacce Michaelpalacce merged commit fff77ba into vmware:main Jun 12, 2024
6 checks passed
@VenelinBakalov
Copy link
Collaborator

Oh, I somehow missed that one, nice one thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michaelpalacce Michaelpalacce Michaelpalacce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@unbreakabl3 @VenelinBakalov @Michaelpalacce