Revert the way config elements are mocked to 2.33.0 functionality

[pe1pip]

Description

Revert the way config elements are mocked to 2.33.0 functionality

Checklist

• [ x] I have added relevant error handling and logging messages to help troubleshooting
• [ x] I have added tests that prove my fix is effective or that my feature works
• [ x] I have added necessary documentation, relevant usage information (if applicable)
• [ x] I have updated CHANGELOG.md with a short summary of the changes introduced
• [ x] I have tested against live environment, if applicable
• [ x] I have synced any structure and/or content vRA-NG improvements with vra-ng and ts-vra-ng archetypes (if applicable)
• [ x] I have my changes rebased and squashed to the minimal number of relevant commits. Notice: don't squash all commits
• [x ] I have added a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

mvn test in vro-scripting-api was successful

Release Notes

Revert the way config elements are mocked to 2.33.0 functionality

Related issues and PRs

Issue #149

[vmwclabot]

@pe1pip, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 18a3359 must be signed by Remco.Post@rabobank.nl
• Commit 54617ba must be signed by Remco.Post@rabobank.nl

[vmwclabot]

@pe1pip, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 18a3359 must be signed by Remco.Post@rabobank.nl
• Commit 54617ba must be signed by Remco.Post@rabobank.nl

[vmwclabot]

@pe1pip, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 18a3359 must be signed by Remco.Post@rabobank.nl
• Commit 54617ba must be signed by Remco.Post@rabobank.nl
• Commit 41b6041 must be signed by Remco.Post@rabobank.nl

[vmwclabot]

@pe1pip, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 18a3359 must be signed by Remco.Post@rabobank.nl
• Commit 54617ba must be signed by Remco.Post@rabobank.nl
• Commit 41b6041 must be signed by Remco.Post@rabobank.nl

[akantchev]

You can do a in-line null check with this.attributes?.find(a => a.name === key)

[pe1pip]

I appreciate the fix, the code is from BT 2.33.0, so I assume that this has always been correct.

[VenelinBakalov]

Hi @pe1pip , I had an internal discussion with the team, let's get this merged to unblock you.
Just check the comment above from @akantchev - whether you need to add a null check or you are sure that there won't be null values.