Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for binding workflow attributes to config element values #263

Merged
merged 5 commits into from
Apr 19, 2024
Merged

Support for binding workflow attributes to config element values #263

merged 5 commits into from
Apr 19, 2024

Commits on Apr 18, 2024

  1. Add the possibility to bind Workflow Attributes to Configuration Elem… 

    …ents.

This is done by providing the following annotation:
```
@workflow({
    id: "<Some Id>",
    name: "<Some Name>",
    path: "<Some Path>",
    attributes: {
        attributeName: {
        type: "string",
        bind: true,
        value: "Some/Path/To/ConfigurationElement/variableName"
        }
    }
})
```
Please note that for the attribute, we have type, bind, and value.
bind is a boolean showing if the attribute is bound to a configuration element.
If so, then value shows the path to the ConfigurationElement and the variable inside it to bind to,
so in the forkflow the attribute value would equal to the value specified in the ConfigurationElement variable.

Signed-off-by: Yordan Nedelchev <ynedelchev@vmware.com>
    @ynedelchev
    ynedelchev committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    b3593fa View commit details
    Browse the repository at this point in the history

  2. 1. Changelog, 2. Tests (End2End], 3. ts archetype update 

    Signed-off-by: Yordan Nedelchev <ynedelchev@vmware.com>
    @ynedelchev
    ynedelchev committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    b6ff5dd View commit details
    Browse the repository at this point in the history

  3. Fix linter issues in documentation 

    Signed-off-by: Yordan Nedelchev <ynedelchev@vmware.com>
    @ynedelchev
    ynedelchev committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    f385145 View commit details
    Browse the repository at this point in the history

  4. Adressing comment: 

    dimitar-nikolov-lazarov Apr 12, 2024

Same as type definitions i other file.
It would be better to specify exactly that the type is dictionary of key: string, any/string(value).
{ [key: string]: any } or { [key: string]: string }

Signed-off-by: Yordan Nedelchev <ynedelchev@vmware.com>
    @ynedelchev
    ynedelchev committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    c4bd92d View commit details
    Browse the repository at this point in the history

  5. Addressing Pull Request Comment: 

    akantchev

    I think the check should be if (id === null)

ynedelchev
    Fixed :)

Signed-off-by: Yordan Nedelchev <ynedelchev@vmware.com>
    @ynedelchev
    ynedelchev committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    3d900ac View commit details
    Browse the repository at this point in the history