Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store the form data as JSON rather than as serialized JSON into string. #261

Merged
merged 7 commits into from
Apr 19, 2024
Merged

Store the form data as JSON rather than as serialized JSON into string. #261

merged 7 commits into from
Apr 19, 2024

Commits on Apr 9, 2024

  1. Store the form data as JSON rather than as serialized JSON into string. 

    Signed-off-by: Yordan Nedelchev <ynedelchev@vmware.com>
    @ynedelchev
    ynedelchev committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    1cc9f6d View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. 1. Tests, 2. Changelog, 3. Update archetypes 

    Signed-off-by: Yordan Nedelchev <ynedelchev@vmware.com>
    @ynedelchev
    ynedelchev committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    90c1f17 View commit details
    Browse the repository at this point in the history

  2. That looks great, could you also update the Release.md file 

    Signed-off-by: Yordan Nedelchev <ynedelchev@vmware.com>
    @ynedelchev
    ynedelchev committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    8de5422 View commit details
    Browse the repository at this point in the history

  3. Fix linting issues. 

    Signed-off-by: Yordan Nedelchev <ynedelchev@vmware.com>
    @ynedelchev
    ynedelchev committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    2e11ae0 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Adressing comment: 

    akantchev 2 hours ago
I think this constructor here is not needed (as it is not used anywhere).

ynedelchev 1 minute ago
As this is a test, my idea was to invoke the constructor in order to verify (assert) that it does not throw an exception.

Changing it to

```
assertDoesNotThrow(() -> new VraNgCustomForm(repoFormSource));
```
and moving it into the `//THEN` section of the test for more clarity.

Signed-off-by: Yordan Nedelchev <ynedelchev@vmware.com>
    @ynedelchev
    ynedelchev committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    0b290e0 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. [Task N/A] Removed unneeded assignment, fixed spelling errors. 

    Signed-off-by: Alexander Kantchev <akantchev@vmware.com>
    @akantchev
    akantchev committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    d13b58d View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Merge branch 'main' into make-form-data-a-pretty-formatted-json-in-ca… 

    …talog-item-metadata

Signed-off-by: Yordan Nedelchev <ynedelchev@vmware.com>
    @ynedelchev
    ynedelchev committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    a985d8c View commit details
    Browse the repository at this point in the history