-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 206: Conditional execution in saga #222
Conversation
@krasimirr, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
1 similar comment
@krasimirr, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
@krasimirr, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
1 similar comment
@krasimirr, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Signed-off-by: Krasimir Rusev <rkrasimir@vmware.com>
4ea5fac
to
6e7a955
Compare
Signed-off-by: Krasimir Rusev <rkrasimir@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job :) a few comments only
conditionalVar: | ||
type: boolean | ||
|
||
tasks: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to add test for workflows as well, ideally separately, so we can figure out where the error is if it happens faster
Signed-off-by: Krasimir Rusev <rkrasimir@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Description
Currently, there are cases when tasks/workflows need to be executed only if a condition is matched based on a saga state value. This feature implements that requirement.
Checklist
Fixed #XXX -
orClosed #XXX -
prefix to auto-close the issueTesting
Release Notes
This feature enables the conditional execution of tasks/workflows based on a conditional variable (saga state value).
Related issues and PRs