IAC-791 Full Support of the vRO Policies Feature

[akashayyappan]

Description

Checklist

• Lint and unit tests pass locally with my changes
• I have added relevant error handling and logging messages to help troubleshooting
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)
• I have updated CHANGELOG.md with a short summary of the changes introduced
• I have tested against live environment, if applicable
• I have added relevant usage information (As-built)
• Any structure and/or content vRA-NG improvements are synchronized with vra-ng and ts-vra-ng archetypes
• Every new or updated Installer property is documented in docs/archive/doc/markdown/use-bundle-installer.md
• Dependencies in pom.xml are up-to-date
• My changes have been rebased and squashed to the minimal number of relevant commits
• My changes have a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Tested the changes with a live enivronment with posibile scenarios.

Release Notes

Implemeneted functionality to support full vRO Policy Feature

Related issues and PRs

Updated the Samples repo files as per the new implementation.
Sample Repo PR: PR-1

[Michaelpalacce]

Seems like the build is failing, lets fix it

[akashayyappan]

Seems like the build is failing, lets fix it

The failure is due to changes in the interface parameters which fails the samples repo build. It is decided to implement versioning to be backward compatible. I'm currently working on it, will update the PR along with the changes mentioned in the comments.

[joroaf]

@akashayyappan let's introduce versioning of the interface and keep backward compatibility.

[Michaelpalacce]

One more content from me regarding the limitation of the element types, also sync with master

[VenelinBakalov]

@Michaelpalacce I see there is 1 change requested by you, is it still valid or we can close the PR?

[VenelinBakalov]

I am linking this PR to close issue #77
@Michaelpalacce @joroaf ping me if I am wrong

[akashayyappan]

I am linking this PR to close issue #77 @Michaelpalacce @joroaf ping me if I am wrong

This PR is for vRO Policies. You can check this task: IAC-791.

[VenelinBakalov]

I see, thanks, link removed

[vmwclabot]

@akashayyappan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit fd7bb8c has a no-reply/unreachable author email address: 48151852+akashayyappan@users.noreply.github.com

[vmwclabot]

@akashayyappan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit fd7bb8c has a no-reply/unreachable author email address: 48151852+akashayyappan@users.noreply.github.com

[vmwclabot]

@akashayyappan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 2abf712 has a no-reply/unreachable author email address: 48151852+akashayyappan@users.noreply.github.com

[vmwclabot]

@akashayyappan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 2abf712 has a no-reply/unreachable author email address: 48151852+akashayyappan@users.noreply.github.com

[vmwclabot]

@akashayyappan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 3d854cb must be signed by ayyappana@vmware.com

[vmwclabot]

@akashayyappan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 3d854cb must be signed by ayyappana@vmware.com

[VenelinBakalov]

Oks, thanks. I see a minor merge conflict in the Changelog, could you check this, in the meantime I will check with @Michaelpalacce

[Michaelpalacce]

2 small changes, otherwise look good

[Michaelpalacce]

I don't see this being used in any way, we've defined it but nothing else, how are we validating this?

[akashayyappan]

Policy Template Versioning was introduced to make the new changes be backward compatible. If user provides version as v2 which is optional, user can create policy with full support.

[vmwclabot]

@akashayyappan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 610339b must be signed by ayyappana@vmware.com

[vmwclabot]

@akashayyappan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 610339b must be signed by ayyappana@vmware.com

[vmwclabot]

@akashayyappan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 610339b must be signed by ayyappana@vmware.com

[vmwclabot]

@akashayyappan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 610339b must be signed by ayyappana@vmware.com

[vmwclabot]

@akashayyappan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 610339b must be signed by ayyappana@vmware.com

[vmwclabot]

@akashayyappan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 610339b must be signed by ayyappana@vmware.com

[github-actions]

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[VenelinBakalov]

@Michaelpalacce could you double check, I think there is a change request on your side, is it still valid?

[unbreakabl3]

Hi, @Michaelpalacce .
Is it possible somehow to fix the merge conflict to start to use it?

[vmwclabot]

@akashayyappan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 610339b must be signed by ayyappana@vmware.com
• Commit d6a279d must be signed by ayyappana@vmware.com
• Commit da3f158 must be signed by ayyappana@vmware.com
• Commit 754a0f0 must be signed by ayyappana@vmware.com

[vmwclabot]

@akashayyappan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 610339b must be signed by ayyappana@vmware.com
• Commit d6a279d must be signed by ayyappana@vmware.com
• Commit da3f158 must be signed by ayyappana@vmware.com
• Commit 754a0f0 must be signed by ayyappana@vmware.com

[vmwclabot]

@akashayyappan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 610339b must be signed by ayyappana@vmware.com
• Commit d6a279d must be signed by ayyappana@vmware.com
• Commit da3f158 must be signed by ayyappana@vmware.com
• Commit 754a0f0 must be signed by ayyappana@vmware.com
• Commit a02654c must be signed by ayyappana@vmware.com

[vmwclabot]

@akashayyappan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 610339b must be signed by ayyappana@vmware.com
• Commit d6a279d must be signed by ayyappana@vmware.com
• Commit da3f158 must be signed by ayyappana@vmware.com
• Commit 754a0f0 must be signed by ayyappana@vmware.com
• Commit a02654c must be signed by ayyappana@vmware.com