Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task IAC-790] Update usage of deprecated vROPs policy (since vROPs 8.12.X) #178

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

akantchev
Copy link
Contributor

[Task IAC-790] Update usage of deprecated vROPs policy (since vROPs 8.12.X)

Description

When pushing vROPs policies on vROPs 8.12.X and later make sure that public API is invoked only (as the older internal API gets deprecated), any internal API calls should be removed, when pushing vROPs policies for older versions of vROPs (prior 8.12.0) make sure that internal API is used only (for backward compatibility).

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added relevant error handling and logging messages to help troubleshooting
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have updated CHANGELOG.md with a short summary of the changes introduced
  • I have tested against live environment, if applicable
  • Dependencies in pom.xml are up-to-date
  • My changes have been rebased and squashed to the minimal number of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Tested by pushing vROPs package that contains policies using vROPs version version 8.12.0 and 8.10 (for backward compatibility) .

Release Notes

Update Deprecated Policy APIs for vROPs 8.12.x.

@akantchev akantchev requested a review from a team as a code owner October 30, 2023 11:49
…ng backward compatibility

Signed-off-by: Alexander Kantchev <akantchev@vmware.com>

Signed-off-by: Alexander Kantchev <akantchev@vmware.com>
@akantchev akantchev force-pushed the IAC-790-update-deprecated-vrops-policy-api branch from 6a3c502 to d64285a Compare October 30, 2023 11:51
@vmware vmware deleted a comment from vmwclabot Oct 30, 2023
@vmware vmware deleted a comment from vmwclabot Oct 31, 2023
Signed-off-by: Alexander Kantchev <akantchev@vmware.com>
@akantchev akantchev merged commit 4b66d34 into main Nov 6, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants