Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump license-maven-plugin versions #405

Closed
bb-erik opened this issue Sep 9, 2024 · 5 comments · Fixed by #409
Closed

Bump license-maven-plugin versions #405

bb-erik opened this issue Sep 9, 2024 · 5 comments · Fixed by #409
Assignees
Labels
area/dependencies Relates to updates to dependency file(s) area/maven Relates to maven changes kind/enhancement Enhancement or improvement of existing features triage/accepted The issue was accepted and will be done version/patch The change is a non-breaking bugfix

Comments

@bb-erik
Copy link

bb-erik commented Sep 9, 2024

Description

I would appreciate if you can update the dependency of license-maven-plugin, but of course you can bump all of them in the pomfile. :)
Thank you!

@VenelinBakalov VenelinBakalov added area/dependencies Relates to updates to dependency file(s) triage/needed Needs to be discussed by project maintainers kind/enhancement Enhancement or improvement of existing features version/patch The change is a non-breaking bugfix area/maven Relates to maven changes labels Sep 9, 2024
@VenelinBakalov VenelinBakalov changed the title Bump maven plugin versions Bump license-maven-plugin versions Sep 9, 2024
@VenelinBakalov
Copy link
Collaborator

Hi @bb-erik , thanks for the suggestion.
Regarding the licensing plugin, sounds good, is there any particular version or functionality you are looking into or "latest and greatest"?
Regarding other plugins, I would suggest to open any specific plugin requests as a separate issue similar to this one, this way we would have good separation and it would be easiest to track, develop and release.

@VenelinBakalov VenelinBakalov added triage/accepted The issue was accepted and will be done and removed triage/needed Needs to be discussed by project maintainers labels Sep 9, 2024
@bb-erik
Copy link
Author

bb-erik commented Sep 9, 2024

Thank you for the fast response @VenelinBakalov!
Latest version for the license-maven-plugin (2.4.0) would be good.
At this point I only need that plugin bumped. If the need for the other ones arises, I will open individual Issues.
Thank you!

@VenelinBakalov VenelinBakalov self-assigned this Sep 9, 2024
VenelinBakalov added a commit that referenced this issue Sep 10, 2024
…in-version

(#405) Bump license-maven-plugin from 2.0.1 to 2.4.0
@VenelinBakalov
Copy link
Collaborator

@bb-erik issue should be solved with #409
At least on my local tests it seems everything is compiling and licenses are being generated the same with 2.4.0. I will keep you posted when we release so you can validate on your side as well.

Another option that I can suggest in case you want to test this early, you can download the repository, checkout the latest main and follow the steps in How to build -> 2. execute to push a build in your local repository. After that in your project you can point the parent artifact to version 2.41.1-SNAPSHOT which is pushed in your local maven repo, and test.
https://github.com/vmware/build-tools-for-vmware-aria/blob/main/README.md

@VenelinBakalov
Copy link
Collaborator

Released with 2.42.0 and available in Maven central:
https://github.com/vmware/build-tools-for-vmware-aria/releases/tag/v2.42.0

@VenelinBakalov
Copy link
Collaborator

@bb-erik fyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Relates to updates to dependency file(s) area/maven Relates to maven changes kind/enhancement Enhancement or improvement of existing features triage/accepted The issue was accepted and will be done version/patch The change is a non-breaking bugfix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants