This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Allow create calls to be idempotent in the VDVS plugin #1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govint
changed the title
shuklanirdesh82
approved these changes
Nov 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the ESX service and plugin to allow create to succeed if the volume already exists. Tested with UCP 2.2.4. Remove of volume is not working owing to a docker side issue where the labels of the nodes in the swarm are different and hence the remove doesn't work. All discussion of the docker side issue is in moby/moby#35334.
Volume inspect is at present not supported in UCP.
Extended a basic test to check for idempotency of create.