This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Fixes escaped spaces from /proc/mounts entries #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes spaces in vol and DS names that appear as escaped sequences in /proc/mount entries
Testing:
Ran container with volume name as "snapvol 4"
/proc/mounts has this,
/dev/disk/by-path/pci-0000:03:00.0-scsi-0:0:0:0 /mnt/vmdk/snapvol\0404@sharedVmfs-0 ext4 rw,relatime,data=ordered 0 0
2017-08-10 09:42:33.230951849 +0000 UTC [INFO] Volume 'snapvol 4@sharedVmfs-0' was found mounted, ref=(&refcount.refCount{count:0x0, mounted:true, dev:"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:0:0:0"})
2017-08-10 09:42:33.231054727 +0000 UTC [INFO] Initiating recovery unmount. name="snapvol 4@sharedVmfs-0" refcnt=0 mounted=true dev="/dev/disk/by-path/pci-0000:03:00.0-scsi-0:0:0:0"
2017-08-10 09:42:33.912167335 +0000 UTC [INFO] Discovered 1 volumes that may be in use.
2017-08-10 09:42:33.912243437 +0000 UTC [INFO] Volume name=snapvol 4@sharedVmfs-0 count=0 mounted=true device='/dev/disk/by-path/pci-0000:03:00.0-scsi-0:0:0:0'
2017-08-10 09:42:33.912251873 +0000 UTC [INFO] Refcounting successfully completed
2017-08-10 09:42:33.912264325 +0000 UTC [INFO] Docker VMDK plugin started mock_esx=false version="vSphere Volume Driver v0.5" port=1019
2017-08-10 09:42:33.912491836 +0000 UTC [INFO] Going into ServeUnix - Listening on Unix socket address="/run/docker/plugins/vsphere.sock"