This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Refactoring vmlistener test #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shaominchen It would be great to have |
1. Split into 2 separate test cases 2. Move constants to common code
shaominchen
force-pushed
the
failover_test
branch
from
8121a2f
to
5a30adb
Compare
|
@shuklanirdesh82 Right now we have to copy/paste excerpts from local test run. It will be ideal if we can improve the test output to have a brief summary report in the end. I will file an issue to track this improvement. |
shuklanirdesh82
approved these changes
Jun 15, 2017
govint
pushed a commit
that referenced
this pull request
Jun 19, 2017
1. Split into 2 separate test cases 2. Move constants to common code
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1422
Testing Done:
=> Running target e2e-test-runalways Wed Jun 7 10:14:48 UTC 2017
OK: 6 passed
--- PASS: Test (134.32s)
=> Running target e2e-test-runonce Wed Jun 7 10:17:05 UTC 2017
OK: 17 passed
--- PASS: Test (385.36s)