Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

[Part 2] Made Admin CLI return proper code to shell #1522

Closed
shuklanirdesh82 opened this issue Jun 29, 2017 · 0 comments
Closed

[Part 2] Made Admin CLI return proper code to shell #1522

shuklanirdesh82 opened this issue Jun 29, 2017 · 0 comments

Comments

@shuklanirdesh82
Copy link
Contributor

#1464 is fixing partially Admin CLI return code .. This issue is tracking the remaining work.

Some more reference from #1464 (comment)

Partially addresses #1411

CLI code used to print error message and exit, without passing proper code to shell.
This PR fixes that.
There may still be some functions which do not return proper status , but at least this fixes the framework

Functions which do not return proper code: example.
set_vol_opts() should return None on success and return "err msg" on error. Currently it prints stuff and always returns success. A quick review of CLI code is needed to make sure all return proper code.
@shuklanirdesh82 shuklanirdesh82 added this to the simba milestone Jun 29, 2017
pshahzeb pushed a commit to pshahzeb/vsphere-storage-for-docker that referenced this issue Jul 6, 2017
1. Maintaining unambiguity through returning proper exit code when command fails along with message print.
2. Removed redundant helper to print the error message and return it.

Fixes vmware-archive#1522
pshahzeb pushed a commit that referenced this issue Jul 6, 2017
#1543)

1. Maintaining unambiguity through returning proper exit code when command fails along with message print.
2. Removed redundant helper to print the error message and return it.

Fixes #1522
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants