[Build/CI] set CMAKE_BUILD_TYPE=release on wheel build #4941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrifiro
changed the title
dtrifiro
force-pushed
the
build-wheels-with-cmake-release
branch
from
d3c9097
to
60f0129
Compare
This builds the Extensions with `-DCMAKE_BUILD_TYPE=Release`, which enables optimizations and disables debugging symbols in the generated build files. This results in a faster and more efficient executable.
mgoin
reviewed
May 21, 2024
Comment on lines
85
to
86
| env: | ||
| CMAKE_BUILD_TYPE: Release # do not compile with debug symbol to reduce wheel size |
There was a problem hiding this comment.
Why does this not satisfy the same requirement? We should decide on one way to specify this environment variable
There was a problem hiding this comment.
Actually that's a good point, I did not see #4602 and I looked at the binaries generated in the 0.4.2 release. Closing this as it's a duplicate. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds the Extensions with
-DCMAKE_BUILD_TYPE=Release, which enables optimizations and disables debugging symbols in the generated build files. This results in faster smaller and more efficient artifacts.Thanks @z103cb @RH-steve-grubb