Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add onConsoleLog #4115

Merged

Conversation

marcelobotega
Copy link
Contributor

Description

Add docs for onConsoleLog.
Close #3632

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@stackblitz
Copy link

stackblitz bot commented Sep 12, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Sep 12, 2023

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit 18168ab
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65002049f748e800076354fc
😎 Deploy Preview https://deploy-preview-4115--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@sheremet-va sheremet-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally! Thank you 🙏🏻

@sheremet-va sheremet-va merged commit 19922d9 into vitest-dev:main Sep 12, 2023
16 of 18 checks passed
@marcelobotega marcelobotega deleted the feature/onconsolelog-docs branch September 12, 2023 08:54
@marcelobotega marcelobotega restored the feature/onconsolelog-docs branch September 12, 2023 09:05
@marcelobotega
Copy link
Contributor Author

@sheremet-va there are a couple of linting errors on the example, it's breaking other PRs. I fixed it on the branch. Is possible to reopen the PR ?

@sheremet-va
Copy link
Member

@sheremet-va there are a couple of linting errors on the example, it's breaking other PRs. I fixed it on the branch. Is possible to reopen the PR ?

No, please open a follow-up PR

LorenzoBloedow pushed a commit to LorenzoBloedow/vitest that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document onConsoleLog
2 participants