Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ShardsQueried to vtbenchstat & misc cleanups #24

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

add ShardsQueried to vtbenchstat & misc cleanups #24

wants to merge 5 commits into from

Conversation

systay
Copy link
Contributor

@systay systay commented Sep 19, 2024 •
edited
Loading

All changes are to vtbenchstat

  • adds ShardsQueried
  • fixes percentage calculation fix
  • makes vtbenchstat testable and adds unit test
  • we depend on vitess versions that make it difficult to build on go 1.22, so adds check in makefile for go1.23

@systay
make sure to run on go 1.23
52288fa 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
also look at shards queried
a1cff6d 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay changed the title make sure to run on go 1.23 add ShardsQueried to vtbenchstat Sep 19, 2024
@systay
update trace & README
584a1c6 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
list queries in same order as the first trace file
5511f6f 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
make vtbenchstat testable and write unit_tests
fc153be 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay marked this pull request as ready for review September 19, 2024 13:54
@systay systay changed the title add ShardsQueried to vtbenchstat add ShardsQueried to vtbenchstat & misc cleanups Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@systay @frouioui