Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add favicons for all templates that are missing them #1935

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

threepointone
Copy link
Contributor

This PR adds favicons for all templates (except for template-vue and template-vue-ts, which already have them) and references these favicons in their corresponding index.html files.

I chose the vite logo (downloaded from the homepage) as the favicon, instead of the framework. Looks nice in the tabs imo.

image

This PR adds favicons for all templates (except for `template-vue and template-vue-ts, which already have them) and references these favicons in their corresponding index.html files.

I chose the vite logo (downloaded from the homepage) as the favicon, instead of the framework. Looks nice in the tabs imo.
@threepointone
Copy link
Contributor Author

Should I replace the vue ones as well?

@yyx990803 yyx990803 merged commit 3fa1d39 into vitejs:main Feb 8, 2021
@threepointone threepointone deleted the favico branch February 8, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants