-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove builder.entireApp
#18028
Open
bluwy
wants to merge
266
commits into
main
Choose a base branch
from
build-app-cli
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: patak-dev <matias.capeletto@gmail.com>
Co-authored-by: Dario Piotrowicz <dario.piotrowicz@gmail.com>
Run & review this pull request in StackBlitz Codeflow. |
Let's discuss about this one after we merge the PR. We can point to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The idea I had for #16471 (comment). Feel free to let me know too if this is a bad idea
What I'm thinking is that
build.entireApp
currently has a different meaning:build()
orcreateBuilder()
With this PR, I removed the
build.entireApp
option entirely and let frameworks manage them themselves.--app
, they should callcreateBuilder
or ensure thevite
CLI is called with--app
build()
(same as before, not changed)--app
, or frameworks can expose an option to pick between both.