Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v6): fix ssrEmitAssets compat #16480

Merged

Conversation

hi-ogawa
Copy link
Collaborator

Description

It looks like there's no internal test case for ssrEmitAssets but I would expect ecosystem CI would fail without this compatibility.

Copy link

stackblitz bot commented Apr 21, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@hi-ogawa hi-ogawa marked this pull request as ready for review April 21, 2024 02:30
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Moved the compat code to where we are handling config.ssr so we have all in one place. We should also respect both ssrEmitAssets true and false

@patak-dev patak-dev merged commit 5c5efe4 into vitejs:v6/environment-api Apr 21, 2024
6 checks passed
@hi-ogawa hi-ogawa deleted the fix-v6-ssrEmitAssets-compat branch April 21, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants