Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade rollup #12965

Merged
merged 2 commits into from
Apr 24, 2023
Merged

chore: upgrade rollup #12965

merged 2 commits into from
Apr 24, 2023

Conversation

antfu
Copy link
Member

@antfu antfu commented Apr 23, 2023

Description

https://twitter.com/antfu7/status/1650254070081355780

image

The build dist gets 0.2MB smaller with this PR :)

@stackblitz
Copy link

stackblitz bot commented Apr 23, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@antfu
Copy link
Member Author

antfu commented Apr 24, 2023

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Apr 24, 2023

📝 Ran ecosystem CI: Open

suite result
astro ✅ success
histoire ✅ success
iles ✅ success
ladle ✅ success
laravel ✅ success
marko ✅ success
nuxt ✅ success
previewjs ✅ success
qwik ✅ success
rakkas ✅ success
sveltekit ✅ success
vite-plugin-ssr ✅ success
vite-plugin-react ✅ success
vite-plugin-react-pages ✅ success
vite-plugin-react-swc ✅ success
vite-plugin-svelte ✅ success
vite-plugin-vue ✅ success
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success
windicss ✅ success

@patak-dev
Copy link
Member

patak-dev commented Apr 24, 2023

Can we ask for a newer Minor version of rollup in a Vite patch? As you said @antfu, folks installing Vite now are already going to get it without using merging this PR. Should we wait for Vite 4.4 here?

Edit: Woooooot! This is incredible 🔥

@antfu
Copy link
Member Author

antfu commented Apr 24, 2023

Ideally, the change in Rollup should be considered a pure optimization that does not change the code behavior of the build. So I'd say it's safe to ship in a patch (as it actually does not make difference for new installs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants