-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: optimize deps option to turn off auto discovery (#13000)
- Loading branch information
Showing
11 changed files
with
124 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
playground/optimize-deps-no-discovery/__tests__/optimize-deps.spec.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import { expect, test } from 'vitest' | ||
import { isBuild, page, readFile } from '~utils' | ||
|
||
test('optimized dep', async () => { | ||
expect(await page.textContent('.optimized-dep')).toBe('[success]') | ||
}) | ||
|
||
test('vue + vuex', async () => { | ||
expect(await page.textContent('.vue')).toMatch(`[success]`) | ||
}) | ||
|
||
test.runIf(!isBuild)('metadata', async () => { | ||
const meta = await readFile('node_modules/.vite/deps/_metadata.json') | ||
expect(meta).toMatch(`"@vitejs/test-dep-no-discovery"`) | ||
expect(meta).not.toMatch(`"vue"`) | ||
expect(meta).not.toMatch(`"vuex"`) | ||
}) |
2 changes: 2 additions & 0 deletions
2
playground/optimize-deps-no-discovery/dep-no-discovery/index.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
// written in cjs, optimization should convert this to esm | ||
module.exports = '[success]' |
6 changes: 6 additions & 0 deletions
6
playground/optimize-deps-no-discovery/dep-no-discovery/package.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"name": "@vitejs/test-dep-no-discovery", | ||
"private": true, | ||
"version": "1.0.0", | ||
"main": "index.js" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
<h1>Optimize Deps</h1> | ||
|
||
<h2>Optimized Dep</h2> | ||
<div class="optimized-dep"></div> | ||
|
||
<h2>Vue & Vuex</h2> | ||
<div class="vue"></div> | ||
|
||
<script> | ||
function text(el, text) { | ||
document.querySelector(el).textContent = text | ||
} | ||
</script> | ||
|
||
<script type="module"> | ||
import msg from '@vitejs/test-dep-no-discovery' | ||
text('.optimized-dep', msg) | ||
|
||
import { createApp } from 'vue' | ||
import { createStore } from 'vuex' | ||
if (typeof createApp === 'function' && typeof createStore === 'function') { | ||
text('.vue', '[success]') | ||
} | ||
</script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
{ | ||
"name": "@vitejs/test-optimize-deps-no-discovery", | ||
"private": true, | ||
"version": "0.0.0", | ||
"scripts": { | ||
"dev": "vite", | ||
"build": "vite build", | ||
"debug": "node --inspect-brk ../../packages/vite/bin/vite", | ||
"preview": "vite preview" | ||
}, | ||
"dependencies": { | ||
"@vitejs/test-dep-no-discovery": "file:./dep-no-discovery", | ||
"vue": "^3.2.47", | ||
"vuex": "^4.1.0" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import { defineConfig } from 'vite' | ||
|
||
// Overriding the NODE_ENV set by vitest | ||
process.env.NODE_ENV = '' | ||
|
||
export default defineConfig({ | ||
optimizeDeps: { | ||
disabled: false, | ||
noDiscovery: true, | ||
include: ['@vitejs/test-dep-no-discovery'], | ||
}, | ||
|
||
build: { | ||
// to make tests faster | ||
minify: false, | ||
// Avoid @rollup/plugin-commonjs | ||
commonjsOptions: { | ||
include: [], | ||
}, | ||
}, | ||
}) |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.