fix: do not error on unresolved commonjs externals

fix #1339
vitejs · Jan 4, 2021 · 60a4708 · 60a4708
1 parent 804c9a3
commit 60a4708
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/packages/vite/src/node/build.ts b/packages/vite/src/node/build.ts
@@ -362,6 +362,12 @@ export function onRollupWarning(
     const id = warning.source
     const importer = warning.importer
 
+    if (importer && /\?commonjs-external$/.test(importer)) {
+      // allow commonjs external...
+      warning.message = chalk.yellow(warning.message)
+      return doWarn()
+    }
+
     if (id && isBuiltin(id)) {
       let importingDep
       if (importer) {