Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vis#4142: add style options of fill & stroke per point #10

Merged
merged 2 commits into from
Sep 13, 2019
Merged

vis#4142: add style options of fill & stroke per point #10

merged 2 commits into from
Sep 13, 2019

Conversation

mojoaxel
Copy link
Member

@mojoaxel mojoaxel commented Aug 6, 2019

This PR was originally introduced by @boorad with almende/vis#4142

  • ✔️ docs
  • ✔️ example

Graph3d data points can now support the following style object in addition to numbers:

{
  "x":1,
  "y":0,
  "z":3686,
  "style": {
    "fill":"red",
    "stroke":"#000"
  }
}

@mojoaxel mojoaxel requested a review from a team August 6, 2019 18:52
@mojoaxel mojoaxel mentioned this pull request Aug 6, 2019
Closed
3 tasks
Thomaash
Thomaash approved these changes Aug 17, 2019
View reviewed changes
Copy link
Member

@Thomaash Thomaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Thomaash Thomaash merged commit 9fc65dd into master Sep 13, 2019
@vis-bot
Copy link
Collaborator

vis-bot commented Sep 13, 2019

🎉 This PR is included in version 5.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomaash Thomaash Thomaash approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mojoaxel @vis-bot @Thomaash @boorad