fix: change transformation setters call order (#2391)

visgl · Jul 5, 2024 · 2c369d0 · 2c369d0
1 parent b47bb12
commit 2c369d0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/src/utils/transform.ts b/src/utils/transform.ts
@@ -57,12 +57,6 @@ export function applyViewStateToTransform(tr: Transform, props: MapboxProps): bo
   const v: Partial<ViewState> = props.viewState || props;
   let changed = false;
 
-  if ('longitude' in v && 'latitude' in v) {
-    const center = tr.center;
-    // @ts-ignore
-    tr.center = new center.constructor(v.longitude, v.latitude);
-    changed = changed || center !== tr.center;
-  }
   if ('zoom' in v) {
     const zoom = tr.zoom;
     tr.zoom = v.zoom;
@@ -82,5 +76,11 @@ export function applyViewStateToTransform(tr: Transform, props: MapboxProps): bo
     changed = true;
     tr.padding = v.padding;
   }
+  if ('longitude' in v && 'latitude' in v) {
+    const center = tr.center;
+    // @ts-ignore
+    tr.center = new center.constructor(v.longitude, v.latitude);
+    changed = changed || center !== tr.center;
+  }
   return changed;
 }
diff --git a/test/src/utils/transform.spec.js b/test/src/utils/transform.spec.js
@@ -90,5 +90,11 @@ test('applyViewStateToTransform', t => {
   changed = applyViewStateToTransform(tr, {viewState: {pitch: 30}});
   t.notOk(changed, 'nothing changed');
 
+  applyViewStateToTransform(tr, {longitude: 0, latitude: 0, zoom: 0});
+  changed = applyViewStateToTransform(tr, {longitude: 12, latitude: 34, zoom: 15});
+  t.ok(changed, 'center and zoom changed');
+  t.equal(tr.zoom, 15, 'zoom is correct');
+  t.equal(tr.center.lat, 34, 'center latitude is correct');
+
   t.end();
 });