Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #1557 where Windows builds fail on GHA due to incompatible NSIS version. #1560

Merged
merged 2 commits into from
Jan 5, 2022

Conversation

scrblue
Copy link
Contributor

@scrblue scrblue commented Jan 4, 2022

As of present just attempts to install a previous version of NSIS. This will likely fail, but I want to see how GHA complains.

@digisomni digisomni added the allow-build-upload Allows the upload of a build for non white-listed users label Jan 4, 2022
@digisomni digisomni changed the title Draft: Attempt to resolve #1557 on Windows builds failing. Resolve #1557 where Windows builds fail on GHA due to incompatible NSIS version. Jan 4, 2022
@digisomni digisomni added this to the 2022.1.1 Selene Release milestone Jan 4, 2022
@digisomni digisomni linked an issue Jan 4, 2022 that may be closed by this pull request
@digisomni digisomni self-requested a review January 4, 2022 07:20
Move to one line.
@digisomni digisomni added CR Approved At least one code reviewer has approved the PR. QA Approved The PR has been tested successfully. labels Jan 5, 2022
@digisomni digisomni merged commit 72b25b7 into vircadia:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
allow-build-upload Allows the upload of a build for non white-listed users bugfix CR Approved At least one code reviewer has approved the PR. QA Approved The PR has been tested successfully.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows builds on GHA do not work.
3 participants