Overhaul the Domain server's onboarding wizard. #1344

Did the setup and when I got to the "Create a username and password for admin panel" I could not see the text areas where things should be input. Attached is a screen cap and you can see the some text area refresh/control icons but the text input area is not visibl

e.

Misterblue · 2021-09-19T15:16:27Z

On setting up an admin account, I made some mistake because I couldn't log into the browser again. Looking at AppData/Roaming/Vircadia - PR1344/domain-server/config.json, I discovered that I had input "Misterblue" and trying to login with "misterblue" failed. Logging in the "Misterblue" worked.
Account names should be case insensitive.

digisomni · 2021-09-19T17:00:04Z

Did the setup and when I got to the "Create a username and password for admin panel" I could not see the text areas where things should be input. Attached is a screen cap and you can see the some text area refresh/control icons but the text input area is not visibl

e.

What browser and version of the browser are you using? Also I notice that you may be using the first build instead of the latest updated build. Though it should work in either case.

Do you have your OS set to use dark or light theme?

Misterblue · 2021-09-19T17:50:04Z

It was the latest chrome. I believe I'm set on light mode. But the other dialogues worked fine, it was just the admin login dialogue that was the wrong colors

ctrlaltdavid · 2021-09-23T23:52:50Z

Did you intend to include the files in the /dist (i.e., build?) directory in the PR?

Yes.

It seems weird to commit files in the /dist (i.e., build) directory.
Also, what is the source of the /dist/spa files? They appear to be "binaries" (i.e., built files) but where they came from (one of the plug-ins, some other codebase, ...) isn't clear.

digisomni · 2021-09-23T23:57:20Z

You're right, it's the quick and easy way to do it. The alternative is to have it trigger like the server-console as a CMake step because it would be necessary for it to be built at compile time using npm then Quasar. I think that's something that can and probably should be setup at some point: a resources bootstrap step that we can toss this and any future NPM commands into.

dist/spa is where the built files go, SPA stands for single page app which is what this is.

ctrlaltdavid · 2021-09-24T00:02:31Z

Some build instructions should be added on how to build and commit updates.

digisomni · 2021-09-24T05:54:51Z

Are there any sorts of specific instructions needed? So far there is a README.md explaining how to work with the project.

ctrlaltdavid · 2021-09-26T19:41:00Z

In the "Build the app" section perhaps something along the lines of...

"This builds the wizard app in the /dist/spa directory."
How these files are used (do you have to manually copy them somewhere in order for the domain server to use them or is it all automatic.
Instructions to check them into source control when make an update to the code.

vircadia-build-notifier · 2021-09-30T11:16:21Z

The following links are available:
build (ubuntu-18.04, full)

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1344/Vircadia-PR1344-8f24c84-_9e2df7dd.exe

ctrlaltdavid

Looks OK though I haven't properly reviewed the Vue-related items because I don't know Vue.

Misterblue

I don't see anything wrong with the Vue code (based on my limited knowledge of same).
Some misc comments and questions were added.

Misterblue · 2021-09-30T23:00:19Z

domain-server/resources/web/web-new/src/boot/axios.ts

+import axios, { AxiosInstance } from "axios";
+import Log from "../modules/utilities/log";
+
+declare module "@vue/runtime-core" {


There should be a comment that is declarization adds ".$axios" reference to all Vue components.

And, is this in addition to the addition of ".$axios" to app.config.globalProperties done below?

Honestly, I couldn't tell you exactly how this works as it's boilerplate since I bootstrapped the project with Quasar CLI to include Axios.

domain-server/resources/web/web-new/src/boot/axios.ts

domain-server/resources/web/web-new/src/components/components/login/MetaverseLogin.vue

domain-server/resources/web/web-new/src/components/dialogs/ConnectMetaverse.vue

domain-server/resources/web/web-new/src/pages/FirstTimeWizard/Index.vue

Misterblue · 2021-10-01T00:06:08Z

domain-server/src/DomainServer.cpp

@@ -86,7 +86,16 @@ bool DomainServer::_getTempName { false };
 QString DomainServer::_userConfigFilename;
 int DomainServer::_parentPID { -1 };

+/// @brief Route a request to the Metaverse server.
+/// @param connection The HTTP connection object.
+/// @param requestUrl The full URL of the request.


The comment should mention the optional 'key' query. This doesn't say much about what a "full URL" could possibly be.

I don't see anything regarding an optional key query in the parameters for this function.

I might have misunderstood the added code. It looks like code was added to check the query parameters on the requestUrl for the presence of different fields. This is not made clear in the description or explanation of the function.

I've updated it. Also the added code replaces the old code. The old code was not working correctly, so I did it a different way while fixing it.

…mni/vircadia into feature/new-domain-wizard

vircadia-build-notifier · 2021-10-01T05:59:27Z

The following links are available:
build (ubuntu-18.04, full)

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1344/Vircadia-PR1344-c28f9b5-_703e0a81.exe

build (self-hosted_debian-11_aarch64, full)

vircadia-build-notifier · 2021-10-01T09:02:28Z

The following links are available:
build (ubuntu-18.04, full)

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1344/Vircadia-PR1344-ce64747-_dda2b8ae.exe

build (self-hosted_debian-11_aarch64, full)

vircadia-build-notifier · 2021-10-02T21:02:30Z

The following links are available:
build (ubuntu-18.04, full)

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1344/Vircadia-PR1344-38ce605-_fe1d8070.exe

build (self-hosted_debian-11_aarch64, full)

vircadia-build-notifier · 2021-10-04T00:54:18Z

The following links are available:
build (ubuntu-18.04, full)

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1344/Vircadia-PR1344-ae5c911-_9df620e4.exe

build (self-hosted_debian-11_aarch64, full)

Misterblue

Worked great.

digisomni and others added 11 commits September 3, 2021 00:06

Initial creation and wizard redirection added.

8f51de6

State of wizard.

31fef9f

Got login working.

da464b2

Metaverse connection is working.

4ae378e

Merge branch 'vircadia:master' into feature/new-domain-wizard

bdd92a3

Complete wizard (1:1 features of original).

1030680

Fix Qt warning: "QString::KeepEmptyParts" -> "Qt::KeepEmptyParts"

74b185f

Get Domain creation working; revise metaverse forwarding. (TLS init f…

c266b00

…ail issue present)

Add skip wizard dialog.

98de885

Update .gitignore

9fcc1bd

Update dist.

78a57c9

digisomni added enhancement New feature or request domain-server Issues related to the domain server in general needs testing (QA) The PR is ready for testing labels Sep 13, 2021

digisomni added this to the 2021.2.0 Selene Release milestone Sep 13, 2021

digisomni requested a review from ctrlaltdavid September 18, 2021 18:40

digisomni added the needs CR (code review) label Sep 18, 2021

digisomni requested review from Misterblue and removed request for Misterblue September 18, 2021 18:40

Add confirm to save credentials; add more UX handling.

1161c5d

ctrlaltdavid reviewed Sep 19, 2021

View reviewed changes

domain-server/src/DomainServer.h Show resolved Hide resolved

Add Doxygen for 'forwardMetaverseAPIRequest' function.

633a195

Update README.md

9e2df7d

ctrlaltdavid approved these changes Sep 30, 2021

View reviewed changes

Misterblue reviewed Oct 1, 2021

View reviewed changes

digisomni added 3 commits September 30, 2021 23:56

CR.

b3a8c0b

Update dist.

8872045

Merge branch 'feature/new-domain-wizard' of https://github.com/digiso…

703e0a8

…mni/vircadia into feature/new-domain-wizard

digisomni added 2 commits October 1, 2021 03:00

Make Axios header application conditional.

7426722

Update dist.

dda2b8a

Update DomainServer.cpp

fe1d807

CR.

9df620e

digisomni requested a review from Misterblue October 3, 2021 22:53

Misterblue approved these changes Oct 4, 2021

View reviewed changes

digisomni added CR Approved At least one code reviewer has approved the PR. QA Approved The PR has been tested successfully. and removed needs testing (QA) The PR is ready for testing needs CR (code review) labels Oct 4, 2021

digisomni merged commit 1d8da47 into vircadia:master Oct 4, 2021

digisomni deleted the feature/new-domain-wizard branch October 4, 2021 20:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Overhaul the Domain server's onboarding wizard. #1344

Overhaul the Domain server's onboarding wizard. #1344

digisomni commented Sep 13, 2021 •

edited

Loading

vircadia-build-notifier commented Sep 13, 2021

vircadia-build-notifier commented Sep 18, 2021

ctrlaltdavid commented Sep 19, 2021

Misterblue commented Sep 19, 2021

Misterblue commented Sep 19, 2021

digisomni commented Sep 19, 2021

Misterblue commented Sep 19, 2021

ctrlaltdavid commented Sep 23, 2021

digisomni commented Sep 23, 2021

ctrlaltdavid commented Sep 24, 2021

digisomni commented Sep 24, 2021

ctrlaltdavid commented Sep 26, 2021

vircadia-build-notifier commented Sep 30, 2021

ctrlaltdavid left a comment

Misterblue left a comment

Misterblue Sep 30, 2021

digisomni Oct 1, 2021

Misterblue Oct 1, 2021

digisomni Oct 1, 2021

Misterblue Oct 1, 2021

digisomni Oct 3, 2021

vircadia-build-notifier commented Oct 1, 2021

vircadia-build-notifier commented Oct 1, 2021

vircadia-build-notifier commented Oct 2, 2021

vircadia-build-notifier commented Oct 4, 2021

Misterblue left a comment

Overhaul the Domain server's onboarding wizard. #1344

Overhaul the Domain server's onboarding wizard. #1344

Conversation

digisomni commented Sep 13, 2021 • edited Loading

vircadia-build-notifier commented Sep 13, 2021

vircadia-build-notifier commented Sep 18, 2021

ctrlaltdavid commented Sep 19, 2021

Misterblue commented Sep 19, 2021

Misterblue commented Sep 19, 2021

digisomni commented Sep 19, 2021

Misterblue commented Sep 19, 2021

ctrlaltdavid commented Sep 23, 2021

digisomni commented Sep 23, 2021

ctrlaltdavid commented Sep 24, 2021

digisomni commented Sep 24, 2021

ctrlaltdavid commented Sep 26, 2021

vircadia-build-notifier commented Sep 30, 2021

ctrlaltdavid left a comment

Choose a reason for hiding this comment

Misterblue left a comment

Choose a reason for hiding this comment

Misterblue Sep 30, 2021

Choose a reason for hiding this comment

digisomni Oct 1, 2021

Choose a reason for hiding this comment

Misterblue Oct 1, 2021

Choose a reason for hiding this comment

digisomni Oct 1, 2021

Choose a reason for hiding this comment

Misterblue Oct 1, 2021

Choose a reason for hiding this comment

digisomni Oct 3, 2021

Choose a reason for hiding this comment

vircadia-build-notifier commented Oct 1, 2021

vircadia-build-notifier commented Oct 1, 2021

vircadia-build-notifier commented Oct 2, 2021

vircadia-build-notifier commented Oct 4, 2021

Misterblue left a comment

Choose a reason for hiding this comment

digisomni commented Sep 13, 2021 •

edited

Loading