Skip to content

Commit

Permalink
Merge pull request #1616 from namark/gha_windows_environment_downgrade
Browse files Browse the repository at this point in the history
Downgraded GHA Windows environment to Server 2019.
  • Loading branch information
digisomni authored Mar 3, 2022
2 parents a8e8951 + 047367b commit beb7bd4
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/master_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
build:
strategy:
matrix:
os: [windows-latest, macOS-10.15, ubuntu-18.04]
os: [windows-2019, macOS-10.15, ubuntu-18.04]
# build_type: [full, client]
build_type: [full]
include:
Expand Down Expand Up @@ -70,7 +70,7 @@ jobs:
echo "APP_TARGET_NAME=Vircadia" >> $GITHUB_ENV
fi
# Windows build variables
if [ "${{ matrix.os }}" = "windows-latest" ]; then
if [ "${{ matrix.os }}" = "windows-2019" ]; then
echo "PYTHON_EXEC=python" >> $GITHUB_ENV
echo "ZIP_COMMAND=7z" >> $GITHUB_ENV
echo "ZIP_ARGS=a" >> $GITHUB_ENV
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/pr_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
strategy:
matrix:
include:
- os: windows-latest
- os: windows-2019
build_type: full
- os: macOS-10.15
build_type: full
Expand Down Expand Up @@ -95,7 +95,7 @@ jobs:
echo "APP_TARGET_NAME=Vircadia" >> $GITHUB_ENV
fi
# Windows build variables
if [ "${{ matrix.os }}" = "windows-latest" ]; then
if [ "${{ matrix.os }}" = "windows-2019" ]; then
echo "PYTHON_EXEC=python" >> $GITHUB_ENV
echo "INSTALLER_EXT=exe" >> $GITHUB_ENV
if [ "${{ matrix.build_type }}" = "full" ]; then
Expand Down Expand Up @@ -226,7 +226,7 @@ jobs:
run: cmake --build . --config $BUILD_TYPE --target assignment-client $CMAKE_BUILD_EXTRA

- name: Build Console
if: matrix.build_type == 'full' || matrix.os == 'windows-latest'
if: matrix.build_type == 'full' || matrix.os == 'windows-2019'
working-directory: ${{runner.workspace}}/build
shell: bash
run: cmake --build . --config $BUILD_TYPE --target packaged-server-console $CMAKE_BUILD_EXTRA
Expand Down Expand Up @@ -292,7 +292,7 @@ jobs:
df -h
- name: Output Installer Logs
if: failure() && matrix.os == 'windows-latest'
if: failure() && matrix.os == 'windows-2019'
shell: bash
working-directory: ${{runner.workspace}}/build
run: cat ./_CPack_Packages/win64/NSIS/NSISOutput.log
Expand Down

0 comments on commit beb7bd4

Please sign in to comment.