Implement new report submittion fragment #129

mjurkus · 2016-12-11T14:14:06Z

New report submission using fragments + MVP + KT.

Any input is appreciated.

TODO:

Show/Hide personal data fields for appropriate report type
Fill personal data if exists
Save personal data for future reuse
Validate personal data
Select current time handling
Fragment Unit tests

mjurkus · 2016-12-11T14:27:58Z

app/src/main/java/lt/vilnius/tvarkau/mvp/interactors/ReportPhotoProviderImpl.kt

+
+    override fun convert(file: File): String {
+        return ImageUtils.convertToBase64EncodedString(context, file)
+                ?: throw RuntimeException("Failed to convert photo ${file.path}")


Not sure if we should fail silently when impossible to convert photo

Can you provide some scenarios when photo conversion will fail in our case ?

OOM when Glide is converting file to bitmap because of huge bounds:

final int requiredWidth = 1600; final int requiredHeight = 1600;

file not found for some reason

because shit happens :)

mjurkus · 2016-12-13T10:45:19Z

Any chance for a review?

vycius

Looks amazing 👍 Really nice MVP implementation.

Left some comments and got one exception while testing.

vycius · 2016-12-13T15:19:41Z

app/src/main/java/lt/vilnius/tvarkau/fragments/BaseFragment.kt

@@ -37,4 +37,8 @@ abstract class BaseFragment : Fragment() {

        analytics.trackCurrentFragment(activity, this)
    }
+
+    override fun onDestroyView() {


I added this one so in super child classes there were lint errors, that super is not called...

vycius · 2016-12-13T15:28:04Z

app/src/main/java/lt/vilnius/tvarkau/mvp/interactors/NewReportInteractorImpl.kt

+
+        return Observable.from(data.photoUrls)
+                .map { photoConverter.convert(it) }
+                .filter { it != null }


There won't null from photoConverter::convert due to RuntimeException if image can't be converterd

Yeah, so we need to decide what to do. With that. Exception?

vycius · 2016-12-13T15:33:26Z

app/src/main/java/lt/vilnius/tvarkau/mvp/presenters/NewReportPresenterImpl.kt

+            return
+        }
+
+        val current = personalDataInteractor.getPersonalData() ?: Profile()


No need to get current user profile. Just pass required values to contructor (preferably convert Profile to KT data class.

What do you mean? Each profile value pass to view?

I mean:

val profile = Profile(reportData.name, LocalDate.parse(reportData.dateOfBirth), reportData.email, reportData.phone) personalDataInteractor.storePersonalData(profile)

In this case new setters are not needed.

vycius · 2016-12-13T15:38:32Z

app/src/main/java/lt/vilnius/tvarkau/entity/Profile.java

@@ -53,8 +47,16 @@ public String getMobilePhone() {
        return mobilePhone;
    }

-    public static Profile returnProfile(Context con) {
-        return SharedPrefsManager.getInstance(con).getUserProfile();
+    public void setBirthday(LocalDate birthday) {


These are not needed you have all required data to pass to constructor

vycius · 2016-12-13T15:40:12Z

app/src/main/java/lt/vilnius/tvarkau/utils/FieldAwareValidator.kt

+        return this
+    }
+
+    fun <E> validate(validator: FieldAwareValidator<E>): FieldAwareValidator<T> {


vycius · 2016-12-13T15:46:18Z

app/src/main/java/lt/vilnius/tvarkau/backend/ApiRequest.java

@@ -11,4 +11,8 @@ public ApiRequest(ApiMethod method, P params) {
        this.id = method.getId();
        this.params = params;
    }
+
+    public P getParams() {


If it's only used for tests use VisibleForTesting

vycius · 2016-12-13T15:50:28Z

app/src/main/java/lt/vilnius/tvarkau/fragments/NewReportFragment.kt

+                reportType = reportType,
+                description = report_problem_description.text.toString(),
+                address = report_problem_location.text.toString(),
+                latitude = locationCords?.latitude,


Use LatLng instead of two doubles

I'd like to avoid using Android dependencies in models.

vycius · 2016-12-13T15:57:56Z

app/src/main/java/lt/vilnius/tvarkau/activity/ReportRegistrationActivity.kt

@@ -2,20 +2,32 @@ package lt.vilnius.tvarkau.activity

 import android.os.Bundle
 import lt.vilnius.tvarkau.BaseActivity
+import lt.vilnius.tvarkau.fragments.NewReportFragment
 import lt.vilnius.tvarkau.fragments.ReportTypeListFragment

 class ReportRegistrationActivity : BaseActivity() {


While testing this PR got:

12-13 17:56:25.045 31875-31875/lt.vilnius.tvarkau E/WindowManager: android.view.WindowLeaked: Activity lt.vilnius.tvarkau.activity.ReportRegistrationActivity has leaked window DecorView@485b2d3[] that was originally added here at android.view.ViewRootImpl.<init>(ViewRootImpl.java:418) at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:331) at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:93) at android.app.Dialog.show(Dialog.java:322) at lt.vilnius.tvarkau.fragments.NewReportFragment.showProgress(NewReportFragment.kt:545) at lt.vilnius.tvarkau.mvp.presenters.NewReportPresenterImpl$submitProblem$3.call(NewReportPresenterImpl.kt:49) at rx.internal.operators.SingleDoOnSubscribe.call(SingleDoOnSubscribe.java:43) at rx.internal.operators.SingleDoOnSubscribe.call(SingleDoOnSubscribe.java:28) at rx.internal.operators.SingleDoOnUnsubscribe.call(SingleDoOnUnsubscribe.java:42) at rx.internal.operators.SingleDoOnUnsubscribe.call(SingleDoOnUnsubscribe.java:28) at rx.Single.subscribe(Single.java:1876) at rx.Single.subscribe(Single.java:1686) at lt.vilnius.tvarkau.mvp.presenters.NewReportPresenterImpl.submitProblem(NewReportPresenterImpl.kt:51) at lt.vilnius.tvarkau.fragments.NewReportFragment.onOptionsItemSelected(NewReportFragment.kt:156) at android.support.v4.app.Fragment.performOptionsItemSelected(Fragment.java:2212) at android.support.v4.app.FragmentManagerImpl.dispatchOptionsItemSelected(FragmentManager.java:2295) at android.support.v4.app.FragmentController.dispatchOptionsItemSelected(FragmentController.java:353) at android.support.v4.app.FragmentActivity.onMenuItemSelected(FragmentActivity.java:414) at android.support.v7.app.AppCompatActivity.onMenuItemSelected(AppCompatActivity.java:198) at android.support.v7.view.WindowCallbackWrapper.onMenuItemSelected(WindowCallbackWrapper.java:107) at android.support.v7.view.WindowCallbackWrapper.onMenuItemSelected(WindowCallbackWrapper.java:107) at android.support.v7.app.ToolbarActionBar$2.onMenuItemClick(ToolbarActionBar.java:69) at android.support.v7.widget.Toolbar$1.onMenuItemClick(Toolbar.java:206) at android.support.v7.widget.ActionMenuView$MenuBuilderCallback.onMenuItemSelected(ActionMenuView.java:777) at android.support.v7.view.menu.MenuBuilder.dispatchMenuItemSelected(MenuBuilder.java:817) at android.support.v7.view.menu.MenuItemImpl.invoke(MenuItemImpl.java:156) at android.support.v7.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:964) at android.support.v7.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:954) at android.support.v7.widget.ActionMenuView.invokeItem(ActionMenuView.java:624) at android.support.v7.view.menu.ActionMenuItemView.onClick(ActionMenuItemView.java:157) at android.view.View.performClick(View.java:5637) at android.view.View$PerformClick.run(View.java:22429) at android.os.Handler.handleCallback(Handler.java:751) at android.os.Handler.dispatchMessage(Handler.java:95) at android.os.Looper.loop(Looper.java:154) at android.app.ActivityThread.main(ActivityThread.java:6119) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)

Device Nexus 5x newest Android version.

Ahh, good catch

vycius · 2016-12-13T16:04:11Z

app/src/main/java/lt/vilnius/tvarkau/fragments/NewReportFragment.kt

+        super.onSaveInstanceState(outState)
+        outState?.let {
+            it.putParcelable(SAVE_LOCATION, locationCords)
+            it.putSerializable(SAVE_PHOTOS, imageFiles)


We have Icepick dependecy. No need to manually save instances.

Doesn't work with KT :/ Or I failed to grasp how should I make it work...

Yup there is issue frankiesardo/icepick#47 with workaround to make KT work with Icepick. IMHO it's better to not use icepick with KT

vycius · 2016-12-13T16:05:34Z

app/src/main/res/layout/fragment_new_report.xml

+                            android:id="@+id/report_problem_submitter_name"
+                            style="@style/NewProblemField"
+                            android:hint="@string/profile_hint_name"
+                            android:inputType="textPersonName"/>


Use textPersonName|textCapWords

vycius · 2016-12-13T16:09:44Z

I think if at least one field was filled and back is pressed it should ask user if he really wants to exit.

vycius · 2016-12-13T20:38:07Z

See travis for failing tests

vycius · 2016-12-13T20:50:40Z

Also IMHO we need events to track user behaviour in this screen. We should track at least submitted report.

mjurkus · 2016-12-13T21:36:43Z

I'll add tracking with separate PR. It's too big already :)

vycius · 2016-12-14T08:37:01Z

Looks awesome.

mjurkus requested review from ViliusKraujutis, vycius and inetaa December 11, 2016 14:14

mjurkus commented Dec 11, 2016

View reviewed changes

mjurkus added 6 commits December 11, 2016 21:15

Implement new report submittion fragment

bcf104d

Display or hide personal profile data fields when needed

d7bd6a0

Prefill and validate personal data

0496c6c

Update navigation after successfull submit

108e52d

Display date time pickers for report date and time selection

7b10c9b

Fix Android 4.x support

700bfbe

mjurkus force-pushed the feature/problem_registration_Form branch from 9686e19 to 700bfbe Compare December 11, 2016 19:15

mjurkus added 6 commits December 11, 2016 21:39

Correctly inflate menu

8565d32

Implement current time setting

0856c7f

Add initial fragment validation tests

59b6a1b

Complete form validation

148cdda

Add photo validation test

18e3b18

Move observeOn before invocations to view

ed55a34

mjurkus changed the title ~~[WIP] Implement new report submittion fragment~~ Implement new report submittion fragment Dec 13, 2016

vycius reviewed Dec 13, 2016

View reviewed changes

Updates based on PR comments

13f1b7a

mjurkus added 2 commits December 13, 2016 23:41

Update PR based on comments

5822204

Fix unit tests

ba32678

vycius approved these changes Dec 14, 2016

View reviewed changes

mjurkus merged commit 5a385f0 into master Dec 14, 2016

mjurkus deleted the feature/problem_registration_Form branch December 14, 2016 08:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement new report submittion fragment #129

Implement new report submittion fragment #129

mjurkus commented Dec 11, 2016 •

edited by GediminasZukas

Loading

mjurkus Dec 11, 2016

vycius Dec 12, 2016

mjurkus Dec 12, 2016

mjurkus commented Dec 13, 2016

vycius left a comment

vycius Dec 13, 2016

mjurkus Dec 13, 2016

vycius Dec 13, 2016

mjurkus Dec 13, 2016

vycius Dec 13, 2016

mjurkus Dec 13, 2016

vycius Dec 13, 2016 •

edited

Loading

vycius Dec 13, 2016

vycius Dec 13, 2016

vycius Dec 13, 2016

vycius Dec 13, 2016

mjurkus Dec 13, 2016

vycius Dec 13, 2016 •

edited

Loading

mjurkus Dec 13, 2016

vycius Dec 13, 2016

mjurkus Dec 13, 2016

vycius Dec 13, 2016

vycius Dec 13, 2016

vycius commented Dec 13, 2016 •

edited

Loading

vycius commented Dec 13, 2016

vycius commented Dec 13, 2016

mjurkus commented Dec 13, 2016

vycius commented Dec 14, 2016

Implement new report submittion fragment #129

Implement new report submittion fragment #129

Conversation

mjurkus commented Dec 11, 2016 • edited by GediminasZukas Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mjurkus commented Dec 13, 2016

vycius left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vycius Dec 13, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vycius Dec 13, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vycius commented Dec 13, 2016 • edited Loading

vycius commented Dec 13, 2016

vycius commented Dec 13, 2016

mjurkus commented Dec 13, 2016

vycius commented Dec 14, 2016

mjurkus commented Dec 11, 2016 •

edited by GediminasZukas

Loading

vycius Dec 13, 2016 •

edited

Loading

vycius Dec 13, 2016 •

edited

Loading

vycius commented Dec 13, 2016 •

edited

Loading