-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra classes in option outerClass #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update the docs with the new changes about outerClass
.
@phucbm |
dev/md/options.md
Outdated
@@ -10,7 +10,7 @@ | |||
| `mobileBreakpoint` | number | `768` | Activate mobile layout when the screen size is <=768px | | |||
| `closeButtonInnerText` | string | `svg/icon` | Custom `innerText` of the close button | | |||
| `triggerSelector` | CSS selector | `""` | Click on this trigger will also toggle the popup | | |||
| `outerClass` | string | `""` | Extra class to popup outer `.easy-popup` | | |||
| `outerClass` | string | `""` | Extra classes to popup outer `.easy-popup` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add this sentence:
Use white space for multiple classes, e.g. "class1 class2"
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated. Can you check it again? Thanks.
This PR resolves this issue: #31