Merge pull request #3 from video-dev/add-b-frame-support-to-presets

add gop_num_b_frames to preset
video-dev · Dec 2, 2019 · 2d7bc88 · 2d7bc88
2 parents e4983dc + fb2b822
commit 2d7bc88
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/presets.go b/presets.go
@@ -59,6 +59,7 @@ type Preset struct {
 	VideoBitrate  string   `xml:"video_description>h264_settings>bitrate,omitempty"`
 	GopSize       string   `xml:"video_description>h264_settings>gop_size,omitempty"`
 	GopMode       string   `xml:"video_description>h264_settings>gop_mode,omitempty"`
+	GopNumBFrames string   `xml:"video_description>h264_settings>gop_num_b_frames,omitempty"`
 	Profile       string   `xml:"video_description>h264_settings>profile,omitempty"`
 	ProfileLevel  string   `xml:"video_description>h264_settings>level,omitempty"`
 	RateControl   string   `xml:"video_description>h264_settings>rate_control_mode,omitempty"`

diff --git a/presets_test.go b/presets_test.go
@@ -186,6 +186,7 @@ func TestGetPreset(t *testing.T) {
 		AudioBitrate:  "128000",
 		GopSize:       "80",
 		GopMode:       "fixed",
+		GopNumBFrames: "0",
 		Profile:       "Baseline",
 		ProfileLevel:  "3",
 		RateControl:   "ABR",
@@ -339,6 +340,7 @@ func TestGetPresetForHls(t *testing.T) {
 		AudioBitrate:  "64000",
 		GopSize:       "90",
 		GopMode:       "fixed",
+		GopNumBFrames: "2",
 		Profile:       "Main",
 		ProfileLevel:  "3.1",
 		RateControl:   "VBR",
@@ -476,6 +478,7 @@ func TestCreatePreset(t *testing.T) {
 		AudioBitrate:  "64000",
 		GopSize:       "90",
 		GopMode:       "fixed",
+		GopNumBFrames: "2",
 		Profile:       "Main",
 		ProfileLevel:  "3.1",
 		RateControl:   "VBR",