Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades: Golang 1.19, Knative v1.9, K8s v1.25.3, Istio 1.16.0, metallb 0.3.19 #667

Merged
merged 10 commits into from
Apr 18, 2023

Conversation

anshalshukla
Copy link
Contributor

@anshalshukla anshalshukla commented Feb 11, 2023

List of upgrades:

  • Golang to 1.19
  • Knative to 1.9
  • k8s to 1.25
  • Istio to 1.16
  • metallb to 0.3.19

WARNING: After this PR, vHive is incompatible with k8s <1.24

@leokondrashov
Copy link
Contributor

I've ran the PR branch through the vHive quickstart guide. Looks fine, in the end invoker runs as expected.

Should there be any other checks before merge?

scripts/cluster/setup_master_node.sh Outdated Show resolved Hide resolved
docs/developers_guide.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@anshalshukla anshalshukla changed the title Knative v1.9, K8s v1.24.0 update Knative v1.9, K8s v1.25.6, Istio 1.16.0 update Feb 17, 2023
@ustiugov
Copy link
Member

@anshalshukla please fix the linter checks. also, please see the error that poped up in the CRI test.

scripts/github_runner/Dockerfile.cri_dev_env Outdated Show resolved Hide resolved
scripts/cluster/setup_master_node.sh Show resolved Hide resolved
scripts/setup_zipkin.sh Outdated Show resolved Hide resolved
@anshalshukla anshalshukla force-pushed the release-1.9 branch 2 times, most recently from c6eb9c0 to 130ba9f Compare February 23, 2023 06:08
@anshalshukla anshalshukla changed the title Knative v1.9, K8s v1.25.6, Istio 1.16.0 update Knative v1.9, K8s v1.25.3, Istio 1.16.0 update Feb 23, 2023
@ustiugov
Copy link
Member

@anshalshukla please investigate the failing unit test (it probably also causes the CRI tests to fail). Also, please squash your commits that belong to the same logical changes into one using git rebase

cvetkovic
cvetkovic previously approved these changes Feb 23, 2023
Copy link
Contributor

@cvetkovic cvetkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anshalshukla
Copy link
Contributor Author

anshalshukla commented Feb 28, 2023

While trying to test CRI test using this. I face the following error while running create_one_node_cluster.sh

Istio has been successfully downloaded into the istio-1.16.0 folder on your system.

Next Steps:
See https://istio.io/latest/docs/setup/install/ to add Istio to your Kubernetes cluster.

To configure the istioctl client tool for your workstation,
add the /users/anshal/vHive/istio-1.16.0/bin directory to your environment path variable with:
	 export PATH="$PATH:/users/anshal/vHive/istio-1.16.0/bin"

Begin the Istio pre-installation check by running:
	 istioctl x precheck 

Need more information? Visit https://istio.io/latest/docs/setup/install/ 
! values.global.jwtPolicy is deprecated; use Values.global.jwtPolicy=third-party-jwt. See https://istio.io/latest/docs/ops/best-practices/security/#configure-third-party-service-account-tokens for more information instead
✔ Istio core installed                                                          
✘ Istiod encountered an error: failed to wait for resource: resources not ready after 5m0s: timed out waiting for the condition
  
✘ Ingress gateways encountered an error: failed to wait for resource: resources not ready after 5m0s: timed out waiting for the condition
  
  
- Pruning removed resources                                                     Error: failed to install manifests: errors occurred during operation
customresourcedefinition.apiextensions.k8s.io/certificates.networking.internal.knative.dev created
customresourcedefinition.apiextensions.k8s.io/configurations.serving.knative.dev created
customresourcedefinition.apiextensions.k8s.io/clusterdomainclaims.networking.internal.knative.dev created
customresourcedefinition.apiextensions.k8s.io/domainmappings.serving.knative.dev created
customresourcedefinition.apiextensions.k8s.io/ingresses.networking.internal.knative.dev created
customresourcedefinition.apiextensions.k8s.io/metrics.autoscaling.internal.knative.dev created
customresourcedefinition.apiextensions.k8s.io/podautoscalers.autoscaling.internal.knative.dev created
customresourcedefinition.apiextensions.k8s.io/revisions.serving.knative.dev created
customresourcedefinition.apiextensions.k8s.io/routes.serving.knative.dev created
customresourcedefinition.apiextensions.k8s.io/serverlessservices.networking.internal.knative.dev created
customresourcedefinition.apiextensions.k8s.io/services.serving.knative.dev created
customresourcedefinition.apiextensions.k8s.io/images.caching.internal.knative.dev created
namespace/knative-serving created

The command eventually ends with a pending external IP for istio-ingressgateway

service/broker-filter created
deployment.apps/mt-broker-ingress created
service/broker-ingress created
deployment.apps/mt-broker-controller created
horizontalpodautoscaler.autoscaling/broker-ingress-hpa created
horizontalpodautoscaler.autoscaling/broker-filter-hpa created
NAME                   TYPE           CLUSTER-IP      EXTERNAL-IP   PORT(S)                                      AGE
istio-ingressgateway   LoadBalancer   10.110.66.203   <pending>     15021:31083/TCP,80:31577/TCP,443:30548/TCP   5m15s

While this is not the case when the CRI test suite runs via the GitHub actions. See this.

On searching for the possible reasons I found a couple of possible reasons for this behaviour.

  1. Lack of RAM. See this
  2. Failed scheduling. See this

I think the problem is with the scheduling because on running kubectl get pods -A. The response shows pods as pending:

NAMESPACE          NAME                                                                          READY   STATUS    RESTARTS   AGE
istio-system       cluster-local-gateway-fffb9f589-xrvk6                                         0/1     Pending   0          32m
istio-system       istio-ingressgateway-778db64bb6-7w5dw                                         0/1     Pending   0          32m
istio-system       istiod-85bf857c79-2pxjt                                                       0/1     Pending   0          37m
knative-eventing   eventing-controller-6b5b744bfd-t86rt                                          0/1     Pending   0          27m
knative-eventing   eventing-webhook-75cdd7c68-fs9k4                                              0/1     Pending   0          27m
knative-eventing   imc-controller-565df566f8-qgvv7                                               0/1     Pending   0          27m
knative-eventing   imc-dispatcher-5bf6c7d945-mxgxq                                               0/1     Pending   0          27m
knative-eventing   mt-broker-controller-575d4c9f77-qm852                                         0/1     Pending   0          27m
knative-eventing   mt-broker-filter-746ddf5785-svsb8                                             0/1     Pending   0          27m
knative-eventing   mt-broker-ingress-7bff548b5b-hv4ll                                            0/1     Pending   0          27m
knative-serving    activator-74ffb7c9b6-js29l                                                    0/1     Pending   0          27m
knative-serving    autoscaler-8586b7f7df-9727m                                                   0/1     Pending   0          27m
knative-serving    controller-5d4fcf8bcf-fhcwb                                                   0/1     Pending   0          27m
knative-serving    default-domain-tmqth                                                          0/1     Pending   0          27m
knative-serving    domain-mapping-55d685d97b-62mn2                                               0/1     Pending   0          27m
knative-serving    domainmapping-webhook-5c5b5979cb-v5lhg                                        0/1     Pending   0          27m
knative-serving    net-istio-controller-777b6b4d89-56rct                                         0/1     Pending   0          27m
knative-serving    net-istio-webhook-78665d59fd-dt6b5                                            0/1     Pending   0          27m
knative-serving    webhook-6894666d8-qvjnh                                                       0/1     Pending   0          27m
kube-system        calico-kube-controllers-6f4474fd5b-wv6dl                                      0/1     Pending   0          37m
kube-system        canal-cmlct                                                                   2/2     Running   0          37m
kube-system        coredns-565d847f94-22w27                                                      1/1     Running   0          37m
kube-system        coredns-565d847f94-s8sh8                                                      1/1     Running   0          37m
kube-system        etcd-node-1.anshal-149188.ntu-cloud-pg0.utah.cloudlab.us                      1/1     Running   0          37m
kube-system        kube-apiserver-node-1.anshal-149188.ntu-cloud-pg0.utah.cloudlab.us            1/1     Running   0          37m
kube-system        kube-controller-manager-node-1.anshal-149188.ntu-cloud-pg0.utah.cloudlab.us   1/1     Running   0          37m
kube-system        kube-proxy-qbw5b                                                              1/1     Running   0          37m
kube-system        kube-scheduler-node-1.anshal-149188.ntu-cloud-pg0.utah.cloudlab.us            1/1     Running   0          37m
metallb-system     controller-588f6c844d-s5f44                                                   0/1     Pending   0          37m
registry           docker-registry-pod-7k8rc                                                     0/1     Pending   0          27m

Also if I run kubectl taint --all node-role.kubernetes.io/control-plane:NoSchedule- and wait for a few minutes, eventualy all the pods get to running state. Then to proceed to next setup of setting up local-registry I had to install go, which is weird because I had used go build to compile vhive. Even after installing go the go run ./examples/registry/populate_registry.go -imageFile ./examples/registry/images.txt fails with the following error:

INFO[0000] Reading the images from the file: ./examples/registry/images.txt 
INFO[0000] Pulling images from docker://docker.io to docker://docker-registry.registry.svc.cluster.local:5000 
INFO[0000] Pulling vhiveease/helloworld:var_workload    
FATA[0000] Failed to pull image vhiveease/helloworld:var_workload: exec: "skopeo": executable file not found in $PATH

Then I tried deploying functions which was successful. Here it again differs with the GitHub actions workflow, which failed while function deployment. Eventually on running the cri tests it failed with the following log:

go: downloading github.com/stretchr/testify v1.8.0
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading gopkg.in/yaml.v3 v3.0.1
=== RUN   TestSingleInvoke
--- PASS: TestSingleInvoke (3.05s)
=== RUN   TestSingleInvokeLocal
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:61
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestSingleInvokeLocal
        	Messages:   	Failed to get response from function
--- FAIL: TestSingleInvokeLocal (0.03s)
=== RUN   TestParallelInvoke
--- PASS: TestParallelInvoke (0.13s)
=== RUN   TestParallelInvokeLocal
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocal
        	Messages:   	Failed to get response from function
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:178
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestParallelInvokeLocalua
        	Messages:   	Failed to get response from function
--- FAIL: TestParallelInvokeLocal (0.19s)
=== RUN   TestAutoscaler
=== RUN   TestAutoscaler/Scale_fn_with_concurrency_1
=== RUN   TestAutoscaler/Scale_from_0
--- PASS: TestAutoscaler (206.28s)
    --- PASS: TestAutoscaler/Scale_fn_with_concurrency_1 (3.28s)
    --- PASS: TestAutoscaler/Scale_from_0 (203.00s)
=== RUN   TestMultipleFuncInvoke
    cri_test.go:166: 
        	Error Trace:	/users/anshal/vHive/cri/cri_test.go:166
        	            				/users/anshal/vHive/cri/cri_test.go:131
        	            				/users/anshal/vHive/cri/asm_amd64.s:1571
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = 
        	Test:       	TestMultipleFuncInvoke
        	Messages:   	Failed to get response from function
--- FAIL: TestMultipleFuncInvoke (3.09s)
=== RUN   TestBench
First invocation took 1026 ms
Second invocation took 8 ms
--- PASS: TestBench (1.17s)
FAIL
coverage: 0.0% of statements
FAIL	github.com/vhive-serverless/vhive/cri	213.975s
FAIL

Studying the logs of local testing and GitHub actions I'm unable to pin point the problem. Logs of actions suggest that there is a setup problem with k8s or kn because of which we are unable to deploy functions but locally the k8s and kn seem to be working fine without any error.

I tried the same steps with the main branch and although the istio setup completed properly eventually the cri-tests fails with mostly the same errors.

Signed-off-by: Anshal Shukla <shukla.anshal85@gmail.com>
Signed-off-by: Anshal Shukla <shukla.anshal85@gmail.com>
Signed-off-by: Anshal Shukla <shukla.anshal85@gmail.com>
Signed-off-by: Anshal Shukla <shukla.anshal85@gmail.com>
Signed-off-by: Anshal Shukla <shukla.anshal85@gmail.com>
Signed-off-by: Anshal Shukla <shukla.anshal85@gmail.com>
Signed-off-by: Anshal Shukla <shukla.anshal85@gmail.com>
@ustiugov ustiugov force-pushed the release-1.9 branch 8 times, most recently from 23cd1fe to c943da8 Compare April 18, 2023 09:06
@ustiugov ustiugov changed the title Knative v1.9, K8s v1.25.3, Istio 1.16.0, metallb 0.3.19 update Upgrades: Golang 1.19, Knative v1.9, K8s v1.25.3, Istio 1.16.0, metallb 0.3.19 Apr 18, 2023
@ustiugov ustiugov force-pushed the release-1.9 branch 2 times, most recently from 6900aed to 8f6bddf Compare April 18, 2023 09:51

replace github.com/vhive-serverless/vhive/function-images/tests/save_load_minio/proto => ../proto_gen

require (
github.com/containerd/containerd v1.4.3
github.com/vhive-serverless/vhive/function-images/tests/save_load_minio/proto v0.0.0-00010101000000-000000000000
github.com/containerd/containerd v1.6.20
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we upgrade this to 1.6.20 without the firecracker-containerd upgrade?

anshalshukla and others added 2 commits April 18, 2023 19:25
and refactored deprecated API of the dependencies (io/utils)

Signed-off-by: Dmitrii Ustiugov <dmitrii.ustiugov@ed.ac.uk>
Signed-off-by: Dmitrii Ustiugov <dmitrii.ustiugov@ed.ac.uk>
Signed-off-by: Dmitrii Ustiugov <dmitrii.ustiugov@ed.ac.uk>
Copy link
Member

@ustiugov ustiugov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready to merge. Thanks a lot to @anshalshukla and @CuriousGeorgiy and the team.

@ustiugov ustiugov merged commit ead2d63 into vhive-serverless:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants