fix(lint): @turbo/workspaces #5810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
|
✅ This change can build |
Linux Benchmark for 1c0fb2bClick to view benchmark
|
🟢 CI successful 🟢Thanks |
MacOS Benchmark for 1c0fb2b
Click to view full benchmark
|
Windows Benchmark for 1c0fb2b
Click to view full benchmark
|
tknickman
force-pushed
the
tomknickman/turbo-1261-fix-turboworkspaces
branch
from
2cc30cf
to
1101d8e
Compare
Linux Benchmark for 2420c9aClick to view benchmark
|
chris-olszewski
approved these changes
Aug 29, 2023
packages/turbo-workspaces/src/cli.ts
Outdated
| @@ -41,13 +40,18 @@ workspacesCli | |||
| .action(summary); | |||
|
|
|||
| workspacesCli.parseAsync().catch((error) => { | |||
| // eslint-disable-next-line no-console | |||
There was a problem hiding this comment.
In #5832 we swap to use our wrapper around console.log, is it worthwhile to switch that here too?
There was a problem hiding this comment.
Yes definitely, I like that method better since we don't need disables everywhere and it consolidates where we're actually logging to the user in case we want to make changes there in the future.
|
Depends on #5827 to fix a bug in the useFixtures test hook that is causing intermittent failures here. |
tknickman
force-pushed
the
tomknickman/turbo-1261-fix-turboworkspaces
branch
from
1101d8e
to
d3ab2c0
Compare
tknickman
force-pushed
the
tomknickman/turbo-1261-fix-turboworkspaces
branch
from
d3ab2c0
to
97942c8
Compare
Linux Benchmark for 3e9633cClick to view benchmark
|
MacOS Benchmark for 3e9633c
Click to view full benchmark
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@turbo/workspaces lint fixes