-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: turborepo integration test glob #3702
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
Failing next.js integration test suitesCommit: 019eb37 Test summary
Full test report
Expand output● Component Stack in error overlay › should show a component stack on hydration error
Expand output● Configurable runtime for src/pages and API routes › In dev mode › warns about API route using experimental-edge runtime
● Configurable runtime for src/pages and API routes › In dev mode › warns about page using edge runtime
● Configurable runtime for src/pages and API routes › In dev mode › errors about page using edge runtime
● Configurable runtime for pages and API routes › In dev mode › warns about API route using experimental-edge runtime
● Configurable runtime for pages and API routes › In dev mode › warns about page using edge runtime
● Configurable runtime for pages and API routes › In dev mode › errors about page using edge runtime
Expand output● CLI Usage › dev › -p conflict
Expand output● Error overlay - editor links › should be possible to open files on RSC build error
● Error overlay - editor links › should be possible to open files on RSC parse error
● Error overlay - editor links › should be possible to open files on module not found error
Expand output● app-dir alias handling › should handle typescript paths alias correctly
● app-dir alias handling › should resolve css imports from outside with src folder presented
Expand output● Handles a broken webpack plugin (precompile) › should render error correctly
Expand output● Component Stack in error overlay › should show a component stack on hydration error
Expand output● Configurable runtime for src/pages and API routes › In dev mode › warns about API route using experimental-edge runtime
● Configurable runtime for src/pages and API routes › In dev mode › warns about page using edge runtime
● Configurable runtime for src/pages and API routes › In dev mode › errors about page using edge runtime
● Configurable runtime for pages and API routes › In dev mode › warns about API route using experimental-edge runtime
● Configurable runtime for pages and API routes › In dev mode › warns about page using edge runtime
● Configurable runtime for pages and API routes › In dev mode › errors about page using edge runtime
Expand output● CLI Usage › dev › -p conflict
Expand output● Error overlay - editor links › should be possible to open files on RSC build error
● Error overlay - editor links › should be possible to open files on RSC parse error
● Error overlay - editor links › should be possible to open files on module not found error
Expand output● app-dir static/dynamic handling › should handle dynamicParams: false correctly
● app-dir static/dynamic handling › should ssr dynamically when detected automatically with fetch cache option
● app-dir static/dynamic handling › should render not found pages correctly and fallback to the default one
● app-dir static/dynamic handling › should ssr dynamically when forced via config
● app-dir static/dynamic handling › should show a message to leave feedback for
Expand output● Handles a broken webpack plugin (precompile) › should render error correctly
|
|
@@ -136,7 +136,9 @@ jobs: | |||
uses: technote-space/get-diff-action@v6 | |||
with: | |||
PATTERNS: | | |||
cli/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this? It's already captured by "Go Related changes" and I think that's used when running e2e and integration tests.
Benchmark for 019eb37Click to view benchmark
|
Expanding the patterns to include any changes to the
cli
directory as well as changingcrates/turborepo*
tocreates/turborepo*/**
which seems to be what we want.Testing:
Under the hood get-diff-action uses minimatch for matching patterns against
git diff
. I quick wrote a test script to verify these patterns should get us what we want:Output: