Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: positioned mask image #566

Merged
merged 3 commits into from
Jan 30, 2024
Merged

fix: positioned mask image #566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d449c4
chore: add positioned mask image test
pjeweb Oct 18, 2023
a00c195
fix: positioned mask image
pjeweb Oct 18, 2023
07c6f0f
Merge branch 'main' into main
shuding Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/builder/mask-image.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ export default async function buildMaskImage(
mask +=
def +
buildXMLString('rect', {
x: 0,
y: 0,
x: left,
y: top,
width,
height,
fill: `url(#${_id})`,
Expand Down
Binary file added ...image-test-tsx-mask-should-support-mask-image-on-positioned-elements-1-snap.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
29 changes: 29 additions & 0 deletions test/mask-image.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,4 +209,33 @@ describe('Mask-*', () => {
)
expect(toImage(svg, 100)).toMatchImageSnapshot()
})

it('should support mask-image on positioned elements', async () => {
const svg = await satori(
<div
style={{
height: '100%',
width: '100%',
display: 'flex',
}}
>
<div
style={{
position: 'absolute',
top: 20,
left: 20,
height: 100,
width: 100,
display: 'flex',
background: 'green',
maskImage:
"url(data:image/svg+xml,%3Csvg viewBox='0 0 100 100' xmlns='http://www.w3.org/2000/svg'%3E%3Crect fill='white' width='100' height='100' /%3E%3C/svg%3E)",
border: '1px solid red',
}}
></div>
</div>,
{ width: 120, height: 120, fonts }
)
expect(toImage(svg, 120)).toMatchImageSnapshot()
})
})
Loading