refactor: load dynamic fonts #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LuciNyan
force-pushed
the
refactor-load-dynamic-fonts
branch
from
44a1c3e
to
e3a4739
Compare
LuciNyan
changed the title
|
Thanks! |
|
🎉 This PR is included in version 0.4.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
sahithyandev
pushed a commit
to sahithyandev/satori
that referenced
this pull request
Apr 26, 2024
Hi! @shuding I have encountered a minor issue. After successfully retrieving the necessary font files on the backend server, I am simply uncertain about the optimal method for transmitting them back to the front end in a single response while also specifying the language for each file. Would you be able to provide me with some guidance on this matter? 🤔️ Closes: vercel#367 --------- Co-authored-by: Shu Ding <g@shud.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a new method for dynamically loading font files. When graphemes are detected through regular expressions as potentially originating from multiple languages, the specific language for which to load the font file is identified through the Google Fonts CSS unicode-range.
Closes: #367