Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mask image always applied to root instead of element #565

Closed
pjeweb opened this issue Oct 18, 2023 · 1 comment · Fixed by #566
Closed

Mask image always applied to root instead of element #565

pjeweb opened this issue Oct 18, 2023 · 1 comment · Fixed by #566
Labels
released

Comments

@pjeweb
Copy link
Contributor

pjeweb commented Oct 18, 2023 •
edited
Loading

Bug report

Description / Observed Behavior

If you apply a mask image to an element, it gets applied relative to the root node (top left most) instead of the offset position of the element.

Expected Behavior

I expected the mask to be applied to the elements bounds.

Reproduction

Reproduction using the same simple mask (just a 100x100 rect) to three elements. One positioned absolute to the top left, one slightly offset (only part of it is visible) and one centered on the canvas being hidden completely.

Additional Context

n/a
@pjeweb pjeweb mentioned this issue Oct 18, 2023
Merged
@pjeweb pjeweb mentioned this issue Oct 25, 2023
Merged
3 tasks
shuding added a commit that referenced this issue Jan 30, 2024
@pjeweb @shuding
fix: positioned mask image (#566)
9bc47fd 
Resolves #565

---------

Co-authored-by: Shu Ding <g@shud.in>
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 0.10.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

sahithyandev pushed a commit to sahithyandev/satori that referenced this issue Apr 26, 2024
@pjeweb @shuding @sahithyandev
fix: positioned mask image (vercel#566)
25168bf 
Resolves vercel#565

---------

Co-authored-by: Shu Ding <g@shud.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: positioned mask image pjeweb/satori
1 participant
@pjeweb