re-arrange some things

vercel · Feb 9, 2024 · 1f62f69 · 1f62f69
1 parent 58ab5c3
commit 1f62f69
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/packages/next/src/client/components/router-reducer/prefetch-cache-utils.ts b/packages/next/src/client/components/router-reducer/prefetch-cache-utils.ts
@@ -116,6 +116,10 @@ export function getOrCreatePrefetchCacheEntry({
   })
 }
 
+/*
+ * Used to take an existing cache entry and prefix it with the nextUrl, if it exists.
+ * This ensures that we don't have conflicting cache entries for the same URL (as is the case with route interception).
+ */
 function prefixExistingPrefetchCacheEntry({
   url,
   nextUrl,
@@ -136,7 +140,7 @@ function prefixExistingPrefetchCacheEntry({
 }
 
 /**
- * Use to seed the prefetch cache with an entry for already-resolved data
+ * Use to seed the prefetch cache with data that has already been fetched.
  */
 export function createPrefetchEntry({
   nextUrl,
@@ -172,7 +176,7 @@ export function createPrefetchEntry({
 }
 
 /**
- * Creates a prefetch entry for data that has not been resolved. This will add the prefetch request to a promise queue.
+ * Creates a prefetch entry entry and enqueues a fetch request to retrieve the data.
  */
 function createLazyPrefetchEntry({
   url,

diff --git a/packages/next/src/client/components/router-reducer/reducers/navigate-reducer.ts b/packages/next/src/client/components/router-reducer/reducers/navigate-reducer.ts
@@ -143,7 +143,7 @@ function navigateReducer_noPPR(
   return data.then(
     ([flightData, canonicalUrlOverride]) => {
       // we only want to mark this once
-      if (prefetchValues && !prefetchValues.lastUsedTime) {
+      if (!prefetchValues.lastUsedTime) {
         // important: we should only mark the cache node as dirty after we unsuspend from the call above
         prefetchValues.lastUsedTime = Date.now()
       }
@@ -196,7 +196,7 @@ function navigateReducer_noPPR(
             currentCache,
             cache,
             flightDataPath,
-            prefetchValues?.kind === 'auto' &&
+            prefetchValues.kind === 'auto' &&
               prefetchEntryCacheStatus === PrefetchCacheEntryStatus.reusable
           )
 
@@ -312,7 +312,7 @@ function navigateReducer_PPR(
   return data.then(
     ([flightData, canonicalUrlOverride, _postponed]) => {
       // we only want to mark this once
-      if (prefetchValues && !prefetchValues.lastUsedTime) {
+      if (!prefetchValues.lastUsedTime) {
         // important: we should only mark the cache node as dirty after we unsuspend from the call above
         prefetchValues.lastUsedTime = Date.now()
       }
@@ -449,7 +449,7 @@ function navigateReducer_PPR(
               currentCache,
               cache,
               flightDataPath,
-              prefetchValues?.kind === 'auto' &&
+              prefetchValues.kind === 'auto' &&
                 prefetchEntryCacheStatus === PrefetchCacheEntryStatus.reusable
             )