Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing variable declaration #773

Merged
merged 2 commits into from
Mar 18, 2022
Merged

Conversation

styfle
Copy link
Member

@styfle styfle commented Sep 13, 2021

I accidentally removed a variable in PR #770

We should convert ncc source code to TS to catch these types of errors.

Update: this variable seems unused 🤷‍♂️

@styfle styfle changed the title Fix missing variable declaration fix: Add missing variable declaration Dec 2, 2021
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you wanna ship, otherwise, 📕! Maybe the side effect was important?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants