fix: prevent duplicate child_(width|height) signals for facet decen…

…dents
vega · Mar 15, 2021 · 5b7ba8d · 5b7ba8d
1 parent 5d7a0a2
commit 5b7ba8d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/compile/facet.ts b/src/compile/facet.ts
@@ -212,7 +212,12 @@ export class FacetModel extends ModelWithField {
     const layoutSignals = assembleLayoutSignals(this);
 
     for (const child of this.children) {
-      layoutSignals.push(...child.assembleLayoutSignals());
+      for (const signal of child.assembleLayoutSignals()) {
+        const currentSignals = layoutSignals.map(s => s.name);
+        if (!currentSignals.includes(signal.name)) {
+          layoutSignals.push(signal);
+        }
+      }
     }
 
     return layoutSignals;

diff --git a/src/compile/layoutsize/assemble.ts b/src/compile/layoutsize/assemble.ts
@@ -76,14 +76,15 @@ export function sizeSignals(model: Model, sizeType: LayoutSizeType): (NewSignal
         update: autosizedFacetExpr(facetParent, sizeType)
       }
     ];
-  } else {
+  } else if (size !== 'merged') {
     return [
       {
         name,
         value: size
       }
     ];
   }
+  return [];
 }
 
 function stepSignal(scaleName: string, range: VgRangeStep): NewSignal {