feat: Expose expression functions #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanitw
reviewed
Jun 7, 2022
test/embed.test.ts
Outdated
| mark: 'point', | ||
| transform: [ | ||
| {calculate: "simpleFunction()", as: "result1"}, | ||
| {calculate: "visitorFunction()", as: "result2"}, |
There was a problem hiding this comment.
visitorFunction -> functionWithVisitor?
src/types.ts
Outdated
| @@ -4,6 +4,8 @@ import {Config as VlConfig} from 'vega-lite'; | |||
| export type Mode = 'vega' | 'vega-lite'; | |||
| export type Config = VlConfig | VgConfig; | |||
|
|
|||
| export type ExpressionFunction = Record<string, Function | {fn: Function, visitor: Function}>; | |||
There was a problem hiding this comment.
Ah my bad, I think visitor should be optional
src/embed.ts
Outdated
| if (opts.expressionFunctions) { | ||
| for (const name in opts.expressionFunctions) { | ||
| const expressionFunction = opts.expressionFunctions[name]; | ||
| if ('fn' in expressionFunction && 'visitor' in expressionFunction) { |
There was a problem hiding this comment.
This won't work correctly if visitor is optional.
use isObject(expressionFunction) instead ?
(you can import isObject from vega, for consistency with other isString, etc.)
|
🚀 PR was released in |
github-actions
bot
added
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes
vega.expressionFunctionto allow consumers to create custom functions/formatters.Follow up to this ticket: #934
Version
Published prerelease version:
v6.21.0-next.0Changelog
🎉 This release contains work from a new contributor! 🎉
Thank you, Zachary Bys (@ZacharyBys), for all your work!
🚀 Enhancement
🐛 Bug Fix
next🔩 Dependency Updates
Authors: 4