Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: import only default from JSON files for webpack 5 #610

Merged
merged 3 commits into from
Dec 24, 2020

Conversation

keller-mark
Copy link
Contributor

Webpack no longer supports using named exports from JSON modules (https://webpack.js.org/migrate/5/#cleanup-the-code)

It looks like a similar update was made in vega-lite here vega/vega-lite#7029

@keller-mark keller-mark changed the title Import only default from JSON files for webpack 5 refactor: import only default from JSON files for webpack 5 Dec 23, 2020
@domoritz domoritz merged commit 99e742d into vega:master Dec 24, 2020
@domoritz
Copy link
Member

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants