Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename set_to_groups and set_to_target #1118

Closed
gaow opened this issue Dec 20, 2018 · 1 comment
Closed

Rename set_to_groups and set_to_target #1118

gaow opened this issue Dec 20, 2018 · 1 comment

Comments

@gaow
Copy link
Member

gaow commented Dec 20, 2018

I changed title for #1114 . Let's discuss new names here if we remove sos_groups and say sos_targets have groups. I was thinking set_each for paired_with and group_with as is.
BoPeng pushed a commit that referenced this issue Dec 21, 2018
Rename set_to_targets with paired_with and set_to_groups with group_w…
dfb99ec 
…ith #1118
@BoPeng
Copy link
Contributor

BoPeng commented Dec 21, 2018

Renamed to paired_with and group_with for backward compatibility.

@BoPeng BoPeng closed this as completed Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaow @BoPeng